omar/panopainter
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Route app viewport scissor through renderer GL

Browse Source
This commit is contained in:
omigamedev
2026-06-03 05:56:57 +02:00
parent 2a030318b1
commit 155e67fcec
6 changed files with 305 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

159
tests/renderer_gl/capabilities_tests.cpp
View File

@@ -27,6 +27,8 @@ struct RecordedOpenGlStateCall {
std::vector<RecordedOpenGlStateCall> recorded_state_calls;
std::vector<std::uint32_t> recorded_string_queries;
std::vector<pp::renderer::gl::OpenGlDefaultClear> recorded_clear_calls;
std::vector<pp::renderer::gl::OpenGlViewportRect> recorded_viewport_calls;
std::vector<pp::renderer::gl::OpenGlScissorRect> recorded_scissor_calls;
void record_enable(std::uint32_t state) noexcept
{
@@ -93,6 +95,27 @@ void record_clear(std::uint32_t mask) noexcept
});
}
void record_viewport(std::int32_t x, std::int32_t y, std::int32_t width, std::int32_t height) noexcept
{
recorded_viewport_calls.push_back(pp::renderer::gl::OpenGlViewportRect {
.x = x,
.y = y,
.width = width,
.height = height,
});
}
void record_scissor(std::int32_t x, std::int32_t y, std::int32_t width, std::int32_t height) noexcept
{
recorded_scissor_calls.push_back(pp::renderer::gl::OpenGlScissorRect {
.enabled = 1U,
.x = x,
.y = y,
.width = width,
.height = height,
});
}
void detects_common_extension_capabilities(pp::tests::Harness& h)
{
constexpr std::array<std::string_view, 2> extensions {
@@ -838,6 +861,136 @@ void rejects_incomplete_app_clear_dispatch(pp::tests::Harness& h)
PP_EXPECT(h, status.code == pp::foundation::StatusCode::invalid_argument);
}
void applies_viewport_dispatch(pp::tests::Harness& h)
{
recorded_viewport_calls.clear();
const auto status = pp::renderer::gl::apply_opengl_viewport(
pp::renderer::gl::OpenGlViewportRect {
.x = 8,
.y = 16,
.width = 1024,
.height = 512,
},
pp::renderer::gl::OpenGlViewportDispatch {
.viewport = record_viewport,
});
PP_EXPECT(h, status.ok());
PP_EXPECT(h, recorded_viewport_calls.size() == 1U);
PP_EXPECT(h, recorded_viewport_calls[0].x == 8);
PP_EXPECT(h, recorded_viewport_calls[0].y == 16);
PP_EXPECT(h, recorded_viewport_calls[0].width == 1024);
PP_EXPECT(h, recorded_viewport_calls[0].height == 512);
}
void rejects_incomplete_viewport_dispatch(pp::tests::Harness& h)
{
const auto status = pp::renderer::gl::apply_opengl_viewport(
pp::renderer::gl::OpenGlViewportRect {
.width = 1,
.height = 1,
},
pp::renderer::gl::OpenGlViewportDispatch {});
PP_EXPECT(h, !status.ok());
PP_EXPECT(h, status.code == pp::foundation::StatusCode::invalid_argument);
}
void applies_scissor_dispatch(pp::tests::Harness& h)
{
recorded_state_calls.clear();
recorded_scissor_calls.clear();
const auto enabled_status = pp::renderer::gl::apply_opengl_scissor_rect(
pp::renderer::gl::OpenGlScissorRect {
.enabled = 1U,
.x = 4,
.y = 12,
.width = 320,
.height = 200,
},
pp::renderer::gl::OpenGlScissorDispatch {
.enable = record_enable,
.disable = record_disable,
.scissor = record_scissor,
});
const auto disabled_status = pp::renderer::gl::apply_opengl_scissor_rect(
pp::renderer::gl::OpenGlScissorRect {},
pp::renderer::gl::OpenGlScissorDispatch {
.enable = record_enable,
.disable = record_disable,
.scissor = record_scissor,
});
PP_EXPECT(h, enabled_status.ok());
PP_EXPECT(h, disabled_status.ok());
PP_EXPECT(h, recorded_state_calls.size() == 2U);
PP_EXPECT(h, recorded_state_calls[0].kind == RecordedOpenGlStateCall::Kind::enable);
PP_EXPECT(h, recorded_state_calls[0].first == 0x0C11U);
PP_EXPECT(h, recorded_state_calls[1].kind == RecordedOpenGlStateCall::Kind::disable);
PP_EXPECT(h, recorded_state_calls[1].first == 0x0C11U);
PP_EXPECT(h, recorded_scissor_calls.size() == 1U);
PP_EXPECT(h, recorded_scissor_calls[0].x == 4);
PP_EXPECT(h, recorded_scissor_calls[0].y == 12);
PP_EXPECT(h, recorded_scissor_calls[0].width == 320);
PP_EXPECT(h, recorded_scissor_calls[0].height == 200);
}
void rejects_incomplete_scissor_dispatch(pp::tests::Harness& h)
{
const auto status = pp::renderer::gl::apply_opengl_scissor_rect(
pp::renderer::gl::OpenGlScissorRect {
.enabled = 1U,
},
pp::renderer::gl::OpenGlScissorDispatch {
.enable = record_enable,
.disable = record_disable,
});
PP_EXPECT(h, !status.ok());
PP_EXPECT(h, status.code == pp::foundation::StatusCode::invalid_argument);
}
void applies_scissor_test_dispatch(pp::tests::Harness& h)
{
recorded_state_calls.clear();
const auto enabled_status = pp::renderer::gl::apply_opengl_scissor_test(
true,
pp::renderer::gl::OpenGlScissorTestDispatch {
.enable = record_enable,
.disable = record_disable,
});
const auto disabled_status = pp::renderer::gl::apply_opengl_scissor_test(
false,
pp::renderer::gl::OpenGlScissorTestDispatch {
.enable = record_enable,
.disable = record_disable,
});
PP_EXPECT(h, enabled_status.ok());
PP_EXPECT(h, disabled_status.ok());
PP_EXPECT(h, recorded_state_calls.size() == 2U);
PP_EXPECT(h, recorded_state_calls[0].kind == RecordedOpenGlStateCall::Kind::enable);
PP_EXPECT(h, recorded_state_calls[0].first == 0x0C11U);
PP_EXPECT(h, recorded_state_calls[1].kind == RecordedOpenGlStateCall::Kind::disable);
PP_EXPECT(h, recorded_state_calls[1].first == 0x0C11U);
}
void rejects_incomplete_scissor_test_dispatch(pp::tests::Harness& h)
{
const auto status = pp::renderer::gl::apply_opengl_scissor_test(
true,
pp::renderer::gl::OpenGlScissorTestDispatch {
.enable = record_enable,
});
PP_EXPECT(h, !status.ok());
PP_EXPECT(h, status.code == pp::foundation::StatusCode::invalid_argument);
}
void maps_renderer_viewports_and_scissors(pp::tests::Harness& h)
{
const auto viewport = pp::renderer::gl::viewport_for_renderer_viewport(
@@ -1218,6 +1371,12 @@ int main()
harness.run("rejects_incomplete_app_runtime_info_dispatch", rejects_incomplete_app_runtime_info_dispatch);
harness.run("clears_app_default_target", clears_app_default_target);
harness.run("rejects_incomplete_app_clear_dispatch", rejects_incomplete_app_clear_dispatch);
harness.run("applies_viewport_dispatch", applies_viewport_dispatch);
harness.run("rejects_incomplete_viewport_dispatch", rejects_incomplete_viewport_dispatch);
harness.run("applies_scissor_dispatch", applies_scissor_dispatch);
harness.run("rejects_incomplete_scissor_dispatch", rejects_incomplete_scissor_dispatch);
harness.run("applies_scissor_test_dispatch", applies_scissor_test_dispatch);
harness.run("rejects_incomplete_scissor_test_dispatch", rejects_incomplete_scissor_test_dispatch);
harness.run("maps_renderer_viewports_and_scissors", maps_renderer_viewports_and_scissors);
harness.run("maps_renderer_blend_state_tokens", maps_renderer_blend_state_tokens);
harness.run("maps_renderer_color_write_masks", maps_renderer_color_write_masks);