From 1d3d524d3b9f95a05b5dd88f88ea876c16854c1e Mon Sep 17 00:00:00 2001 From: omigamedev Date: Sat, 13 Jun 2026 23:07:39 +0200 Subject: [PATCH] Promote stroke draw dual pass shader task --- docs/modernization/tasks.md | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/docs/modernization/tasks.md b/docs/modernization/tasks.md index 926b6fc..8ba1d0d 100644 --- a/docs/modernization/tasks.md +++ b/docs/modernization/tasks.md @@ -755,6 +755,34 @@ Validation: ctest --preset desktop-fast --build-config Debug -R "pp_paint_renderer_compositor|pp_paint_renderer_stroke_execution" --output-onfailure ``` +### STR-026 - Extract Stroke Draw Dual Pass Shader Setup Wrapper + +Status: Ready +Score: +1 renderer boundary and OpenGL parity +Debt: `DEBT-0036` +Scope: `src/canvas.cpp`, `src/legacy_canvas_stroke_execution_services.h`, `tests/paint_renderer/compositor_tests.cpp` + +Goal: + +Move the inline dual-pass shader setup lambda in `Canvas::stroke_draw()` into +a retained helper so the dual-pass branch owns only concrete shader selection +and framebuffer wiring. + +Done Checks: + +- `Canvas::stroke_draw()` no longer contains the inline dual-pass shader + setup lambda. +- Regression coverage proves the extracted helper preserves shader setup + behavior. +- `docs/modernization/debt.md` records the reduced dual-pass shader-setup + surface. + +Validation: + +```powershell +ctest --preset desktop-fast --build-config Debug -R "pp_paint_renderer_compositor|pp_paint_renderer_stroke_execution" --output-onfailure +``` + Progress Notes: - 2026-06-13: `NodeStrokePreview::draw_stroke_immediate()` now routes final