Extract cloud download post-transfer helper
This commit is contained in:
@@ -18,6 +18,12 @@ agent or engineer to remove them without reconstructing context from chat.
|
|||||||
|
|
||||||
## Recent Reductions
|
## Recent Reductions
|
||||||
|
|
||||||
|
- 2026-06-15: `DEBT-0038` was narrowed again. The retained cloud download
|
||||||
|
post-transfer open/close sequence in `execute_cloud_download_thread()` now
|
||||||
|
routes through a focused helper in `src/legacy_cloud_services.cpp` instead
|
||||||
|
of living inline in the retained worker body; the remaining cloud bridge
|
||||||
|
debt stays concentrated in retained prompt/progress lifetime, OpenGL
|
||||||
|
context guarding, and the still-retained transfer-thread execution model.
|
||||||
- 2026-06-15: `DEBT-0038` was narrowed again. The retained cloud download
|
- 2026-06-15: `DEBT-0038` was narrowed again. The retained cloud download
|
||||||
URL construction and progress-callback wiring in
|
URL construction and progress-callback wiring in
|
||||||
`execute_cloud_download_thread()` now routes through a focused helper in
|
`execute_cloud_download_thread()` now routes through a focused helper in
|
||||||
|
|||||||
@@ -192,6 +192,11 @@ The retained cloud download URL construction and progress-callback wiring in
|
|||||||
`src/legacy_cloud_services.cpp`, so the remaining cloud bridge debt is
|
`src/legacy_cloud_services.cpp`, so the remaining cloud bridge debt is
|
||||||
further concentrated on retained prompt/progress lifetime, OpenGL context
|
further concentrated on retained prompt/progress lifetime, OpenGL context
|
||||||
guarding, and the still-retained transfer-thread execution model.
|
guarding, and the still-retained transfer-thread execution model.
|
||||||
|
The retained cloud download post-transfer open/close sequence in
|
||||||
|
`execute_cloud_download_thread()` now also routes through a focused helper in
|
||||||
|
`src/legacy_cloud_services.cpp`, so the remaining cloud bridge debt is
|
||||||
|
further concentrated on retained prompt/progress lifetime, OpenGL context
|
||||||
|
guarding, and the still-retained transfer-thread execution model.
|
||||||
|
|
||||||
Recent 2026-06-13 retained preview reductions continue to narrow DEBT-0036:
|
Recent 2026-06-13 retained preview reductions continue to narrow DEBT-0036:
|
||||||
`NodeStrokePreview::draw_stroke_immediate()` now also routes
|
`NodeStrokePreview::draw_stroke_immediate()` now also routes
|
||||||
|
|||||||
@@ -1126,6 +1126,39 @@ Completed Task Log:
|
|||||||
| Date | Task | Score | Validation | Commit |
|
| Date | Task | Score | Validation | Commit |
|
||||||
| --- | --- | ---: | --- | --- |
|
| --- | --- | ---: | --- | --- |
|
||||||
| 2026-06-15 | ADP-029 | no score movement | `powershell -ExecutionPolicy Bypass -File scripts\\automation\\quiet-validate.ps1 -BuildTargets pano_cli -TestRegex "pp_app_core_document_cloud"` | `65d762c6` |
|
| 2026-06-15 | ADP-029 | no score movement | `powershell -ExecutionPolicy Bypass -File scripts\\automation\\quiet-validate.ps1 -BuildTargets pano_cli -TestRegex "pp_app_core_document_cloud"` | `65d762c6` |
|
||||||
|
|
||||||
|
### ADP-030 - Extract Cloud Download Post-Transfer Helper
|
||||||
|
|
||||||
|
Status: Done
|
||||||
|
Score: no score movement
|
||||||
|
Debt: `DEBT-0038`
|
||||||
|
Scope: `src/legacy_cloud_services.cpp` only
|
||||||
|
|
||||||
|
Goal:
|
||||||
|
|
||||||
|
Reduce the inline retained cloud download post-transfer open/close surface by
|
||||||
|
extracting the final worker-step path from `execute_cloud_download_thread()`
|
||||||
|
into a focused helper while preserving current behavior.
|
||||||
|
|
||||||
|
Done Checks:
|
||||||
|
|
||||||
|
- The retained cloud download post-transfer open/close path no longer lives
|
||||||
|
inline in `execute_cloud_download_thread()`.
|
||||||
|
- The retained cloud download post-transfer open/close path now routes through
|
||||||
|
a focused helper in `src/legacy_cloud_services.cpp`.
|
||||||
|
- `DEBT-0038` and the roadmap note the reduced remaining cloud bridge
|
||||||
|
surface.
|
||||||
|
|
||||||
|
Validation:
|
||||||
|
|
||||||
|
```powershell
|
||||||
|
powershell -ExecutionPolicy Bypass -File scripts\automation\quiet-validate.ps1 -BuildTargets pano_cli -TestRegex "pp_app_core_document_cloud"
|
||||||
|
```
|
||||||
|
|
||||||
|
Completed Task Log:
|
||||||
|
|
||||||
|
| Date | Task | Score | Validation | Commit |
|
||||||
|
| --- | --- | ---: | --- | --- |
|
||||||
| 2026-06-15 | ADP-007 | +1 legacy adapter retirement | `ctest --preset desktop-fast --build-config Debug -R "pp_app_core_app_dialog\|pp_ui_core_node_lifetime\|pp_ui_core_overlay_lifetime" --output-on-failure`; `ctest --preset desktop-fast --build-config Debug -R "pp_app_core_main_toolbar" --output-on-failure`; `MSBuild.exe out\build\windows-msvc-default\tests\pp_app_core_main_toolbar_tests.vcxproj /p:Configuration=Debug /p:Platform=x64`; `MSBuild.exe out\build\windows-msvc-default\panopainter_app.vcxproj /p:Configuration=Debug /p:Platform=x64` | `8db859cb` |
|
| 2026-06-15 | ADP-007 | +1 legacy adapter retirement | `ctest --preset desktop-fast --build-config Debug -R "pp_app_core_app_dialog\|pp_ui_core_node_lifetime\|pp_ui_core_overlay_lifetime" --output-on-failure`; `ctest --preset desktop-fast --build-config Debug -R "pp_app_core_main_toolbar" --output-on-failure`; `MSBuild.exe out\build\windows-msvc-default\tests\pp_app_core_main_toolbar_tests.vcxproj /p:Configuration=Debug /p:Platform=x64`; `MSBuild.exe out\build\windows-msvc-default\panopainter_app.vcxproj /p:Configuration=Debug /p:Platform=x64` | `8db859cb` |
|
||||||
|
|
||||||
### RND-001 - Make Pure Equirectangular Export The Primary Success Path
|
### RND-001 - Make Pure Equirectangular Export The Primary Success Path
|
||||||
|
|||||||
@@ -138,6 +138,15 @@ void execute_cloud_download_transfer(
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
void open_downloaded_project_and_close_dialog(
|
||||||
|
App& app,
|
||||||
|
const pp::app::CloudDownloadRequest& request,
|
||||||
|
const std::shared_ptr<NodeMessageBox>& dialog)
|
||||||
|
{
|
||||||
|
execute_legacy_downloaded_project_open(app, request.selected_path, request.selected_name);
|
||||||
|
pp::panopainter::close_legacy_dialog_node(*dialog);
|
||||||
|
}
|
||||||
|
|
||||||
void execute_cloud_upload_transfer(
|
void execute_cloud_upload_transfer(
|
||||||
App& app,
|
App& app,
|
||||||
std::string filename,
|
std::string filename,
|
||||||
@@ -190,9 +199,7 @@ void execute_cloud_download_thread(
|
|||||||
|
|
||||||
auto m = create_cloud_download_progress_dialog(app);
|
auto m = create_cloud_download_progress_dialog(app);
|
||||||
execute_cloud_download_transfer_with_progress_dialog(app, request, m);
|
execute_cloud_download_transfer_with_progress_dialog(app, request, m);
|
||||||
|
open_downloaded_project_and_close_dialog(app, request, m);
|
||||||
execute_legacy_downloaded_project_open(app, request.selected_path, request.selected_name);
|
|
||||||
pp::panopainter::close_legacy_dialog_node(*m);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
void launch_cloud_download_thread(
|
void launch_cloud_download_thread(
|
||||||
|
|||||||
Reference in New Issue
Block a user