From 2e520709ddb5056e6fba4e039be359ac31ce5727 Mon Sep 17 00:00:00 2001
From: omigamedev <omarator@gmail.com>
Date: Mon, 15 Jun 2026 21:24:37 +0200
Subject: [PATCH] Extract cloud browser dialog helper

---
 docs/modernization/debt.md    |  6 ++++++
 docs/modernization/roadmap.md |  5 +++++
 docs/modernization/tasks.md   | 34 ++++++++++++++++++++++++++++++++++
 src/legacy_cloud_services.cpp |  9 +++++++--
 4 files changed, 52 insertions(+), 2 deletions(-)

diff --git a/docs/modernization/debt.md b/docs/modernization/debt.md
index 7fedd39f..4c3d1415 100644
--- a/docs/modernization/debt.md
+++ b/docs/modernization/debt.md
@@ -18,6 +18,12 @@ agent or engineer to remove them without reconstructing context from chat.
 
 ## Recent Reductions
 
+- 2026-06-15: `DEBT-0038` was narrowed again. The retained cloud browser
+  dialog creation path in `LegacyCloudServices::show_browser()` now routes
+  through a focused helper in `src/legacy_cloud_services.cpp` instead of
+  living inline in the retained service method; the remaining cloud bridge
+  debt stays concentrated in retained prompt/progress lifetime, OpenGL
+  context guarding, and the still-retained transfer-thread execution model.
 - 2026-06-15: `DEBT-0038` was narrowed again. The retained cloud publish
   prompt path in `LegacyCloudServices::prompt_publish()` now routes through a
   focused helper in `src/legacy_cloud_services.cpp` instead of living inline
diff --git a/docs/modernization/roadmap.md b/docs/modernization/roadmap.md
index 9895da7d..9ea17cc9 100644
--- a/docs/modernization/roadmap.md
+++ b/docs/modernization/roadmap.md
@@ -172,6 +172,11 @@ The retained cloud publish prompt path in
 helper in `src/legacy_cloud_services.cpp`, so the remaining cloud bridge debt
 is further concentrated on retained prompt/progress lifetime, OpenGL context
 guarding, and the still-retained transfer-thread execution model.
+The retained cloud browser dialog creation path in
+`LegacyCloudServices::show_browser()` now also routes through a focused helper
+in `src/legacy_cloud_services.cpp`, so the remaining cloud bridge debt is
+further concentrated on retained prompt/progress lifetime, OpenGL context
+guarding, and the still-retained transfer-thread execution model.
 
 Recent 2026-06-13 retained preview reductions continue to narrow DEBT-0036:
 `NodeStrokePreview::draw_stroke_immediate()` now also routes
diff --git a/docs/modernization/tasks.md b/docs/modernization/tasks.md
index c18ec5ed..f55d5f1c 100644
--- a/docs/modernization/tasks.md
+++ b/docs/modernization/tasks.md
@@ -979,6 +979,40 @@ Completed Task Log:
 | Date | Task | Score | Validation | Commit |
 | --- | --- | ---: | --- | --- |
 | 2026-06-15 | ADP-025 | no score movement | `MSBuild.exe out\build\windows-msvc-default\panopainter_app.vcxproj /p:Configuration=Debug /p:Platform=x64`; `ctest --preset desktop-fast --build-config Debug -R "pp_app_core_document_cloud" --output-on-failure` | `777579ff` |
+
+### ADP-026 - Extract Cloud Browser Dialog Helper
+
+Status: Done
+Score: no score movement
+Debt: `DEBT-0038`
+Scope: `src/legacy_cloud_services.cpp` only
+
+Goal:
+
+Reduce the inline retained cloud browser dialog surface by extracting
+the dialog creation path from `LegacyCloudServices::show_browser()`
+into a focused helper while preserving current behavior.
+
+Done Checks:
+
+- The retained cloud browser dialog creation path no longer lives inline in
+  `LegacyCloudServices::show_browser()`.
+- The retained cloud browser dialog creation path now routes through a
+  focused helper in `src/legacy_cloud_services.cpp`.
+- `DEBT-0038` and the roadmap note the reduced remaining cloud bridge
+  surface.
+
+Validation:
+
+```powershell
+& 'C:\Program Files\Microsoft Visual Studio\18\Community\MSBuild\Current\Bin\MSBuild.exe' out\build\windows-msvc-default\panopainter_app.vcxproj /p:Configuration=Debug /p:Platform=x64
+ctest --preset desktop-fast --build-config Debug -R "pp_app_core_document_cloud" --output-on-failure
+```
+
+Completed Task Log:
+
+| Date | Task | Score | Validation | Commit |
+| --- | --- | ---: | --- | --- |
 | 2026-06-15 | ADP-007 | +1 legacy adapter retirement | `ctest --preset desktop-fast --build-config Debug -R "pp_app_core_app_dialog\|pp_ui_core_node_lifetime\|pp_ui_core_overlay_lifetime" --output-on-failure`; `ctest --preset desktop-fast --build-config Debug -R "pp_app_core_main_toolbar" --output-on-failure`; `MSBuild.exe out\build\windows-msvc-default\tests\pp_app_core_main_toolbar_tests.vcxproj /p:Configuration=Debug /p:Platform=x64`; `MSBuild.exe out\build\windows-msvc-default\panopainter_app.vcxproj /p:Configuration=Debug /p:Platform=x64` | `8db859cb` |
 
 ### RND-001 - Make Pure Equirectangular Export The Primary Success Path
diff --git a/src/legacy_cloud_services.cpp b/src/legacy_cloud_services.cpp
index 3cf9c454..dfbaf70a 100644
--- a/src/legacy_cloud_services.cpp
+++ b/src/legacy_cloud_services.cpp
@@ -267,6 +267,12 @@ void wire_cloud_browser_ok_button(
     };
 }
 
+void show_cloud_browser_dialog(App& app)
+{
+    auto dialog = pp::panopainter::create_legacy_cloud_browser_dialog_overlay(app);
+    wire_cloud_browser_ok_button(dialog, &app);
+}
+
 void show_cloud_save_required_warning(App& app);
 
 class LegacyCloudServices final : public pp::app::CloudServices {
@@ -307,8 +313,7 @@ public:
 
     void show_browser() override
     {
-        auto dialog = pp::panopainter::create_legacy_cloud_browser_dialog_overlay(app_);
-        wire_cloud_browser_ok_button(dialog, &app_);
+        show_cloud_browser_dialog(app_);
     }
 
     void start_download(const pp::app::CloudDownloadRequest& request) override