Move app dialog overlays to checked handles
This commit is contained in:
@@ -34,11 +34,11 @@ auditable steps rather than by subjective estimates.
|
||||
| Build and CMake ownership | 15 | 13 | Root CMake owns active source lists, app/tool targets, and retained package entrypoints. |
|
||||
| Test and automation coverage | 15 | 9 | Headless, platform, package, and focused validation commands exist and are current. |
|
||||
| Pure component behavior ownership | 15 | 8 | Behavior lives in `pp_*` components and is consumed by live adapters. |
|
||||
| Legacy adapter retirement | 20 | 9 | `legacy_*_services` and singleton bridges are deleted or reduced to trivial composition. |
|
||||
| Legacy adapter retirement | 20 | 10 | `legacy_*_services` and singleton bridges are deleted or reduced to trivial composition. |
|
||||
| Renderer boundary and OpenGL parity | 15 | 11 | Live render/export/readback paths execute through renderer interfaces with parity checks. |
|
||||
| Platform and package parity | 10 | 8 | Required platforms have root CMake/package validation and injected platform services. |
|
||||
| Hardening and future backend readiness | 10 | 4 | Edge, fuzz, golden, stress, and backend-lab gates exist for high-risk paths. |
|
||||
| **Total** | **100** | **63** | Only completed tasks below may change this number. |
|
||||
| **Total** | **100** | **64** | Only completed tasks below may change this number. |
|
||||
|
||||
When updating `Current`, add a dated note under "Completed Task Log" with the
|
||||
task id, points moved, validation command, and commit hash.
|
||||
@@ -259,6 +259,38 @@ ctest --preset desktop-fast --build-config Debug -R "pp_ui_core_overlay_lifetime
|
||||
cmake --build --preset windows-msvc-default --config Debug --target PanoPainter
|
||||
```
|
||||
|
||||
### ADP-006 - Move App-Owned Dialog Overlays To Checked Handles
|
||||
|
||||
Status: Done
|
||||
Score: +1 legacy adapter retirement
|
||||
Debt: `DEBT-0058`, `DEBT-0063`
|
||||
Scope: `src/legacy_ui_overlay_services.*`, `src/legacy_app_dialog_services.*`,
|
||||
dialog tests only
|
||||
|
||||
Goal:
|
||||
|
||||
Move the retained app-owned progress/message/input dialog overlays off the
|
||||
attach-only root insertion path so the factory-owned live dialogs participate in
|
||||
the checked overlay lifetime registry before broader dialog cleanup.
|
||||
|
||||
Done Checks:
|
||||
|
||||
- `App::show_progress`, `App::message_box`, and `App::input_box` still preserve
|
||||
existing captions, cancel behavior, and keyboard behavior.
|
||||
- `create_legacy_progress_dialog_overlay`, `create_legacy_message_dialog_overlay`,
|
||||
and `create_legacy_input_dialog_overlay` open through checked overlay handles
|
||||
when the main layout anchor is available instead of only attaching raw root
|
||||
children.
|
||||
- `DEBT-0058` and `DEBT-0063` describe the reduced app-dialog lifetime surface
|
||||
and the remaining retained dialog families.
|
||||
|
||||
Validation:
|
||||
|
||||
```powershell
|
||||
ctest --preset desktop-fast --build-config Debug -R "pp_app_core_app_dialog|pp_ui_core_node_lifetime|pp_ui_core_overlay_lifetime" --output-on-failure
|
||||
cmake --build --preset windows-msvc-default --config Debug --target PanoPainter
|
||||
```
|
||||
|
||||
### RND-001 - Make Pure Equirectangular Export The Primary Success Path
|
||||
|
||||
Status: Done
|
||||
|
||||
Reference in New Issue
Block a user