From 3e1b1890a2b15c8b06ba79381925e2fc6f505a3e Mon Sep 17 00:00:00 2001 From: omigamedev Date: Mon, 15 Jun 2026 22:22:18 +0200 Subject: [PATCH] Record ADP-043 closeout --- docs/modernization/debt.md | 5 +++++ docs/modernization/roadmap.md | 4 ++++ docs/modernization/tasks.md | 36 +++++++++++++++++++++++++++++++++++ 3 files changed, 45 insertions(+) diff --git a/docs/modernization/debt.md b/docs/modernization/debt.md index a84093a3..392b8048 100644 --- a/docs/modernization/debt.md +++ b/docs/modernization/debt.md @@ -18,6 +18,11 @@ agent or engineer to remove them without reconstructing context from chat. ## Recent Reductions +- 2026-06-15: `DEBT-0042` was narrowed again. The retained Save Version dialog + wiring in `src/app_dialogs.cpp` now routes through a focused helper instead + of living inline in `App::dialog_save_ver()`; the remaining document-session + bridge debt stays concentrated in close prompts, save dialogs, app document + field mutation, and keyboard/dialog cleanup. - 2026-06-15: `DEBT-0042` was narrowed again. The retained Save dialog button wiring in `src/app_dialogs.cpp` now routes through a focused helper instead of living inline in `App::dialog_save()`; the remaining document-session diff --git a/docs/modernization/roadmap.md b/docs/modernization/roadmap.md index d2eb2e5a..46787caa 100644 --- a/docs/modernization/roadmap.md +++ b/docs/modernization/roadmap.md @@ -1428,6 +1428,10 @@ The retained Save dialog button wiring in `src/app_dialogs.cpp` now also routes through a focused helper, so the remaining document-session bridge debt is further concentrated on close prompts, save-version routing, app document field mutation, and keyboard/dialog cleanup. +The retained Save Version dialog wiring in `src/app_dialogs.cpp` now also +routes through a focused helper, so the remaining document-session bridge debt +is further concentrated on close prompts, save dialogs, app document field +mutation, and keyboard/dialog cleanup. `App::dialog_newdoc` now routes accepted new-document plans through the app-core new-document executor and `src/legacy_document_session_services.*`, preserving target overwrite prompts, legacy canvas resize/layer setup, history diff --git a/docs/modernization/tasks.md b/docs/modernization/tasks.md index 5dddb69a..3910160c 100644 --- a/docs/modernization/tasks.md +++ b/docs/modernization/tasks.md @@ -1595,6 +1595,42 @@ Completed Task Log: | --- | --- | ---: | --- | --- | | 2026-06-15 | ADP-042 | no score movement | `powershell -ExecutionPolicy Bypass -File scripts\\automation\\quiet-validate.ps1 -BuildTargets pano_cli,pp_app_core_document_session_tests -TestRegex "pp_app_core_document_session|pano_cli_plan_document_session_prompt"` | `98c48c33` | +### ADP-043 - Extract Document-Session Save-Version Dialog Helper + +Status: Done +Score: no score movement +Debt: `DEBT-0042` +Scope: `src/app_dialogs.cpp` only + +Closeout: `ffda49ad` + +Goal: + +Reduce the inline retained Save Version dialog surface by extracting the +version-save button handling from `App::dialog_save_ver()` into a focused +helper while preserving current behavior. + +Done Checks: + +- The retained Save Version dialog wiring no longer lives inline in + `App::dialog_save_ver()`. +- The retained Save Version dialog path now routes through a focused helper + in `src/app_dialogs.cpp`. +- `DEBT-0042` and the roadmap note the reduced remaining document-session + bridge surface. + +Validation: + +```powershell +powershell -ExecutionPolicy Bypass -File scripts\\automation\\quiet-validate.ps1 -BuildTargets pano_cli,pp_app_core_document_session_tests -TestRegex "pp_app_core_document_session|pano_cli_plan_document_session_prompt" +``` + +Completed Task Log: + +| Date | Task | Score | Validation | Commit | +| --- | --- | ---: | --- | --- | +| 2026-06-15 | ADP-043 | no score movement | `powershell -ExecutionPolicy Bypass -File scripts\\automation\\quiet-validate.ps1 -BuildTargets pano_cli,pp_app_core_document_session_tests -TestRegex "pp_app_core_document_session|pano_cli_plan_document_session_prompt"` | `ffda49ad` | + ### RND-001 - Make Pure Equirectangular Export The Primary Success Path Status: Done