Centralize legacy document session bridge

docs/modernization/build-inventory.md

@@ -584,14 +584,21 @@ Known local toolchain state:
   progress-total decisions.
 - `pp_app_core_document_session_tests` covers clean and dirty app session,
   document-open action planning and executor dispatch/rejection, save-request,
-  save-before-workflow, new-document target/resolution/overwrite planning,
-  document file target, combined save-file overwrite planning, and save-version
-  target decisions without requiring a window, canvas, or message box.
+  close-request executor dispatch/no-op preservation, document-save executor
+  dispatch/no-op preservation, save-before-workflow executor dispatch,
+  new-document target/resolution/overwrite planning, document file target,
+  combined save-file overwrite planning, and save-version target decisions
+  without requiring a window, canvas, or message box.
 - `src/legacy_document_open_services.*` is the current app-shell bridge between
   `pp_app_core` document-open plans and live ABR/PPBR import prompts,
   unsaved-project discard prompts, project opening, layer UI refresh, title
   updates, and action-history clearing; remaining legacy execution ownership is
   tracked by `DEBT-0039`.
+- `src/legacy_document_session_services.*` is the current app-shell bridge
+  between `pp_app_core` document-session decisions and live close prompts,
+  save dialogs, save-version routing, existing-project saves, and
+  save-before-workflow prompts; retained legacy UI/canvas execution remains
+  tracked by `DEBT-0040`.
 - `src/legacy_history_services.*` is the current app-shell bridge between
   `pp_app_core` history plans and legacy `ActionManager`; toolbar and
   `NodeCanvas` hotkeys share it while document-history extraction remains

docs/modernization/debt.md

@@ -57,6 +57,7 @@ agent or engineer to remove them without reconstructing context from chat.
 | DEBT-0037 | Open | Modernization | Recording lifecycle/export planning and execution dispatch now consume pure `pp_app_core` through `App::rec_start`, `App::rec_stop`, `App::rec_clear`, `App::rec_export`, `pano_cli plan-recording-session`, and the `RecordingServices` boundary; live execution is centralized in `src/legacy_recording_services.*`, but the bridge still owns legacy recording thread startup/shutdown, platform recorded-file cleanup, progress UI, PBO readback through `App::rec_loop`, and `MP4Encoder::write_mp4` execution | Preserve current timelapse/MP4 behavior while recording moves toward app/document/renderer/video services | `pp_app_core_document_recording_tests`; `pano_cli plan-recording-session --running --frame-count 12`; `pano_cli plan-recording-session --platform-clears-files`; `ctest --preset desktop-fast --build-config Debug` | Recording thread lifecycle, frame readback, platform cleanup, progress reporting, and MP4 writing are owned by injected app/renderer/video services with `App` methods acting only as adapters |
 | DEBT-0038 | Open | Modernization | Cloud upload/browse/bulk planning and execution dispatch now consume pure `pp_app_core` through `App::cloud_upload`, `App::cloud_upload_all`, `App::cloud_browse`, `pano_cli plan-cloud-upload`, `pano_cli plan-cloud-upload-all`, `pano_cli plan-cloud-browse`, and the `CloudServices` boundary; live execution is centralized in `src/legacy_cloud_services.*`, but the bridge still uses legacy save-before-upload, `upload`/`download` network helpers, progress/message UI, OpenGL context guarding, `NodeDialogCloud`, `Canvas` project open, layer refresh, and `ActionManager` reset | Preserve current cloud behavior while cloud/network/document import flows move toward app/document/platform services | `pp_app_core_document_cloud_tests`; `pano_cli plan-cloud-upload --new-document --unsaved`; `pano_cli plan-cloud-browse --selected-file demo.ppi`; `pano_cli plan-cloud-upload-all --file-count 3`; `ctest --preset desktop-fast --build-config Debug` | Cloud upload/download, save-before-upload, progress reporting, cloud browse dialog, downloaded project opening, layer refresh, OpenGL context ownership, and action-history reset are owned by injected app/document/network/platform/renderer services with `App` methods acting only as adapters |
 | DEBT-0039 | Open | Modernization | Document-open planning and execution dispatch now consume pure `pp_app_core` through `App::open_document`, `pano_cli plan-open-route`, `DocumentOpenServices`, and `src/legacy_document_open_services.*`, but the bridge still opens ABR/PPBR import prompts, launches legacy brush preset import threads, applies unsaved-project discard prompts, calls legacy project-open execution, refreshes layer UI, updates the app title, and clears legacy history directly | Preserve current file-open/import behavior while document loading and brush import move toward app/document/asset/UI services | `pp_app_core_document_route_tests`; `pp_app_core_document_session_tests`; `pano_cli plan-open-route --path D:/Paint/Scenes/demo.ppi --unsaved`; `pano_cli plan-open-route --path D:/Paint/Brushes/clouds.ABR --unsaved`; `ctest --preset desktop-fast --build-config Debug` | Brush import prompting/execution, project-open execution, unsaved-project discard prompting, layer refresh, title updates, and history clearing are owned by injected app/document/asset/UI services with `App::open_document` acting only as an adapter |
+| DEBT-0040 | Open | Modernization | Close request, document save, and save-before-workflow planning/execution dispatch now consume pure `pp_app_core` through `App::request_close`, `App::save_document`, `App::continue_document_workflow_after_optional_save`, `pano_cli simulate-app-session`, `DocumentSaveServices`, `CloseRequestServices`, `DocumentWorkflowServices`, and `src/legacy_document_session_services.*`, but the bridge still opens legacy message boxes/save dialogs, calls `Canvas::I->project_save`, mutates the unsaved flag on close confirmation, invokes native app close, and routes save-version through the retained legacy dialog | Preserve current close/save/dirty-workflow behavior while document session execution moves toward app/document/UI/platform services | `pp_app_core_document_session_tests`; `pano_cli simulate-app-session --unsaved --save-intent save-dirty-version`; `pano_cli simulate-app-session --no-canvas`; `pano_cli plan-document-file --work-dir D:/Paint --name demo --target-exists`; `pano_cli plan-document-version --directory D:/Paint --doc-name demo.01 --existing-path D:/Paint/demo.02.ppi`; `ctest --preset desktop-fast --build-config Debug` | Close prompt execution, native close requests, dirty-workflow save prompts, existing-project saves, save dialogs, save-version execution, and unsaved-flag mutation are owned by injected app/document/UI/platform services with `App` methods acting only as adapters |
 
 ## Closed Debt
 

docs/modernization/roadmap.md

@@ -733,6 +733,12 @@ behind the renderer boundary.
 unsaved-project discard prompts, project open, layer refresh, title updates,
 and history clearing while those live effects remain tracked under
 `DEBT-0039`.
+`App::request_close`, `App::save_document`, and
+`App::continue_document_workflow_after_optional_save` now route through
+app-core document-session executors and `src/legacy_document_session_services.*`,
+preserving close prompts, save dialogs, save-version routing, existing-project
+save execution, and dirty-workflow save-before-continue prompts while retained
+legacy UI/canvas behavior remains tracked under `DEBT-0040`.
 
 Implementation tasks:
 
@@ -1272,6 +1278,15 @@ Results:
 - Focused document-open CTest coverage passed for
   `pp_app_core_document_route_tests`, `pp_app_core_document_session_tests`, and
   the `pano_cli_plan_open_route_*` smoke tests after the live bridge split.
+- `PanoPainter`, `pp_app_core_document_session_tests`, and `pano_cli` built
+  after close request, document save, and dirty-workflow continuation execution
+  moved behind document-session services. A clean rebuild was required once
+  because MSVC reported the known Debug PDB `LNK1103` corruption, after which
+  the build passed.
+- Focused document-session CTest coverage passed for
+  `pp_app_core_document_session_tests`, `pano_cli_simulate_app_session_*`, and
+  `pano_cli_plan_document_file/version_*` smoke tests after the live bridge
+  split.
 - `pp_app_core_document_recording_tests` passed, covering recording start/stop,
   clear, platform recorded-file cleanup, frame-count reset, export progress
   totals, and oversized progress-total clamping.