Record document browse helper closeout

This commit is contained in:
2026-06-15 22:28:22 +02:00
parent 294d9ce74f
commit 459ace29e3
3 changed files with 46 additions and 0 deletions

View File

@@ -58,6 +58,12 @@ agent or engineer to remove them without reconstructing context from chat.
prompt; the remaining document-open bridge debt stays concentrated in
unsaved-project prompts, project-open execution, layer refresh, title
updates, and retained history services.
- 2026-06-15: `DEBT-0039` was narrowed again. The retained document-browse
button wiring in `App::dialog_browse()` now routes through a focused helper
in `src/app_dialogs.cpp` instead of living inline in the retained browse
dialog method; the remaining document-open bridge debt stays concentrated in
unsaved-project prompts, project-open execution, layer refresh, title
updates, and retained history services.
- 2026-06-15: `DEBT-0038` was narrowed again. The retained cloud downloaded-
project open camera reset and layer-clear setup in
`execute_legacy_downloaded_project_open()` now routes through a focused

View File

@@ -1391,6 +1391,10 @@ The retained ABR/PPBR import prompt wiring in `src/legacy_document_open_services
now also routes through a focused helper, so the remaining document-open bridge
debt is further concentrated on unsaved-project prompts, project-open
execution, layer refresh, title updates, and retained history services.
The retained document-browse button wiring in `App::dialog_browse()` now also
routes through a focused helper, so the remaining document-open bridge debt is
further concentrated on unsaved-project prompts, project-open execution, layer
refresh, title updates, and retained history services.
`App::request_close`, `App::save_document`, and
`App::continue_document_workflow_after_optional_save` now route through
app-core document-session executors and `src/legacy_document_session_services.*`,

View File

@@ -1631,6 +1631,42 @@ Completed Task Log:
| --- | --- | ---: | --- | --- |
| 2026-06-15 | ADP-043 | no score movement | `powershell -ExecutionPolicy Bypass -File scripts\\automation\\quiet-validate.ps1 -BuildTargets pano_cli,pp_app_core_document_session_tests -TestRegex "pp_app_core_document_session|pano_cli_plan_document_session_prompt"` | `ffda49ad` |
### ADP-044 - Extract Document-Browse Dialog Helper
Status: Done
Score: no score movement
Debt: `DEBT-0039`
Scope: `src/app_dialogs.cpp` only
Closeout: `294d9ce7`
Goal:
Reduce the inline retained Browse dialog surface by extracting the
button-handling logic from `App::dialog_browse()` into a focused helper while
preserving current behavior.
Done Checks:
- The retained Browse dialog wiring no longer lives inline in
`App::dialog_browse()`.
- The retained Browse dialog path now routes through a focused helper in
`src/app_dialogs.cpp`.
- `DEBT-0039` and the roadmap note the reduced remaining document-open bridge
surface.
Validation:
```powershell
powershell -ExecutionPolicy Bypass -File scripts\\automation\\quiet-validate.ps1 -BuildTargets pano_cli -TestRegex "pp_app_core_document_session|pano_cli_plan_document_session_prompt"
```
Completed Task Log:
| Date | Task | Score | Validation | Commit |
| --- | --- | ---: | --- | --- |
| 2026-06-15 | ADP-044 | no score movement | `powershell -ExecutionPolicy Bypass -File scripts\\automation\\quiet-validate.ps1 -BuildTargets pano_cli -TestRegex "pp_app_core_document_session|pano_cli_plan_document_session_prompt"` | `294d9ce7` |
### RND-001 - Make Pure Equirectangular Export The Primary Success Path
Status: Done