omar/panopainter
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Extract cloud browser item creation helper

Browse Source
This commit is contained in:
omigamedev
2026-06-15 20:48:59 +02:00
parent 0ba7eb8331
commit 45f08ee8e4
5 changed files with 82 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
docs/modernization/debt.md
View File

File diff suppressed because one or more lines are too long

5
docs/modernization/roadmap.md
View File

@@ -119,6 +119,11 @@ The cloud-browser file-list request/response handling in
helper in `src/node_dialog_cloud.*`, so the remaining cloud bridge debt is
further concentrated on prompt/progress lifetime, OpenGL context guarding,
`NodeDialogCloud` thumbnail execution, and transfer-thread execution.
The cloud-browser slot creation and selection wiring in
`NodeDialogCloud::load_thumbs_thread()` now also route through a focused
helper in `src/node_dialog_cloud.*`, so the remaining cloud bridge debt is
further concentrated on prompt/progress lifetime, OpenGL context guarding,
`NodeDialogCloud` thumbnail execution, and transfer-thread execution.
Recent 2026-06-13 retained preview reductions continue to narrow DEBT-0036:
`NodeStrokePreview::draw_stroke_immediate()` now also routes

35
docs/modernization/tasks.md
View File

@@ -625,6 +625,41 @@ Completed Task Log:
| --- | --- | ---: | --- | --- |
| 2026-06-15 | ADP-015 | no score movement | `MSBuild.exe out\build\windows-msvc-default\panopainter_app.vcxproj /p:Configuration=Debug /p:Platform=x64`; `ctest --preset desktop-fast --build-config Debug -R "pp_app_core_document_cloud" --output-on-failure` | `b06211fa` |
### ADP-016 - Extract Cloud Browser Item Creation Helper
Status: Done
Score: no score movement
Debt: `DEBT-0038`
Scope: `src/node_dialog_cloud.*` only
Goal:
Reduce the inline retained cloud-browser loader surface in
`NodeDialogCloud::load_thumbs_thread()` by extracting the slot-creation and
selection-wiring loop into a focused helper while preserving current behavior.
Done Checks:
- The cloud-browser slot-creation and selection-wiring loop no longer lives
inline in `NodeDialogCloud::load_thumbs_thread()`.
- The retained cloud-browser item creation path now routes through a focused
helper in `src/node_dialog_cloud.*`.
- `DEBT-0038` and the roadmap note the reduced remaining `NodeDialogCloud`
surface.
Validation:
```powershell
& 'C:\Program Files\Microsoft Visual Studio\18\Community\MSBuild\Current\Bin\MSBuild.exe' out\build\windows-msvc-default\panopainter_app.vcxproj /p:Configuration=Debug /p:Platform=x64
ctest --preset desktop-fast --build-config Debug -R "pp_app_core_document_cloud" --output-on-failure
```
Completed Task Log:
| Date | Task | Score | Validation | Commit |
| --- | --- | ---: | --- | --- |
| 2026-06-15 | ADP-016 | no score movement | `MSBuild.exe out\build\windows-msvc-default\panopainter_app.vcxproj /p:Configuration=Debug /p:Platform=x64`; `ctest --preset desktop-fast --build-config Debug -R "pp_app_core_document_cloud" --output-on-failure` | `(pending)` |
Completed Task Log:
| Date | Task | Score | Validation | Commit |