From 57c2d1bfa4e7092b4511bab3aaf38bfbce49d931 Mon Sep 17 00:00:00 2001 From: omigamedev Date: Wed, 17 Jun 2026 16:07:05 +0200 Subject: [PATCH] Remove legacy platform shim from root app graph --- cmake/PanoPainterSources.cmake | 2 -- docs/modernization/debt.md | 5 +++++ docs/modernization/roadmap.md | 7 +++++++ docs/modernization/tasks.md | 7 +++++++ 4 files changed, 19 insertions(+), 2 deletions(-) diff --git a/cmake/PanoPainterSources.cmake b/cmake/PanoPainterSources.cmake index d6ebb6b8..b0242fde 100644 --- a/cmake/PanoPainterSources.cmake +++ b/cmake/PanoPainterSources.cmake @@ -180,8 +180,6 @@ set(PP_PANOPAINTER_APP_SOURCES src/legacy_document_open_services.h src/legacy_document_session_services.cpp src/legacy_document_session_services.h - src/platform_legacy/legacy_platform_services.cpp - src/platform_legacy/legacy_platform_services.h ${PP_PLATFORM_WEB_SOURCES} src/version.cpp ) diff --git a/docs/modernization/debt.md b/docs/modernization/debt.md index 53e2aefd..146578cc 100644 --- a/docs/modernization/debt.md +++ b/docs/modernization/debt.md @@ -18,6 +18,11 @@ agent or engineer to remove them without reconstructing context from chat. ## Reductions +- 2026-06-17: `DEBT-0017`/`DEBT-0055` were narrowed again. + `src/platform_legacy/legacy_platform_services.*` is no longer compiled into + the root `panopainter_app` source graph. The retained shim still exists on + disk for non-root compatibility consumers, but the root Windows/Android/Apple + modernization matrix no longer links it into the live app target. - 2026-06-17: `DEBT-0017`/`DEBT-0050`/`DEBT-0053`/`DEBT-0057` were narrowed again. `webgl/src/main.cpp` now binds a concrete `src/platform_web/web_platform_services.*` `PlatformServices` instance diff --git a/docs/modernization/roadmap.md b/docs/modernization/roadmap.md index e19f4285..c78c7c3f 100644 --- a/docs/modernization/roadmap.md +++ b/docs/modernization/roadmap.md @@ -70,6 +70,13 @@ What is already real: - `pp_app_core` Latest slice: +- `cmake/PanoPainterSources.cmake` no longer adds + `src/platform_legacy/legacy_platform_services.*` to + `PP_PANOPAINTER_APP_SOURCES`, so the root `panopainter_app` target graph + stops compiling and linking that retained fallback shim. +- The retained `platform_legacy` adapter still exists on disk for non-root + compatibility paths, but it is no longer part of the root modernization app + graph validated by the quiet Windows/Android/Apple matrix. - `src/platform_web/web_platform_services.*` now owns the concrete WebGL `PlatformServices` implementation as well as the narrower `WebPlatformServices` helper surface. diff --git a/docs/modernization/tasks.md b/docs/modernization/tasks.md index a78b06f9..9413d8fb 100644 --- a/docs/modernization/tasks.md +++ b/docs/modernization/tasks.md @@ -84,6 +84,13 @@ Completed, blocked, and superseded task history moved to the queue is now ordered by code movement instead. Current slice: +- `cmake/PanoPainterSources.cmake` no longer adds + `src/platform_legacy/legacy_platform_services.*` to + `PP_PANOPAINTER_APP_SOURCES`. +- The root `panopainter_app` modernization graph no longer compiles or links + the retained `platform_legacy` fallback shim. +- The retained file still exists on disk for non-root compatibility consumers, + but it is now outside the validated root app target graph. - `src/platform_web/web_platform_services.*` now owns the concrete Web `PlatformServices` implementation and `webgl/src/main.cpp` now binds that owned service directly at the WebGL entrypoint.