From 5891d2839d36f0b596f499ef053b4156fe00007a Mon Sep 17 00:00:00 2001 From: omigamedev Date: Sat, 13 Jun 2026 16:50:10 +0200 Subject: [PATCH] Extract stroke dual pass boundary --- docs/modernization/tasks.md | 6 ++++++ src/canvas.cpp | 1 - src/legacy_canvas_stroke_execution_services.h | 1 - 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/docs/modernization/tasks.md b/docs/modernization/tasks.md index da5b158..84ee43a 100644 --- a/docs/modernization/tasks.md +++ b/docs/modernization/tasks.md @@ -509,6 +509,12 @@ Done Checks: Progress Notes: +- 2026-06-13: `Canvas::stroke_draw()` dual-brush replay now routes shader + setup, brush-tip texture binding, live-pass execution, and brush-tip + unbinding through `execute_legacy_canvas_stroke_dual_pass(...)`; the live + adapter still owns the concrete texture callbacks and face-frame replay. + Next slice should target another narrow `stroke_draw()` seam without + reopening landed pad or sample helpers. - 2026-06-13: `Canvas::stroke_draw()` dual-brush replay now routes shader setup, brush-tip texture binding, live-pass execution, and brush-tip unbinding through `execute_legacy_canvas_stroke_dual_pass(...)`; the live diff --git a/src/canvas.cpp b/src/canvas.cpp index 77dd2a1..77cc35b 100644 --- a/src/canvas.cpp +++ b/src/canvas.cpp @@ -919,7 +919,6 @@ void Canvas::stroke_draw() pp::panopainter::execute_legacy_canvas_stroke_dual_pass( pp::panopainter::LegacyCanvasStrokeDualPassRequest { .context = "Canvas::stroke_draw", - .planes = dual_pass_texture_bindings, .setup_dual_shader = [&] { pp::panopainter::setup_legacy_stroke_dual_shader( stroke_material.dual_pass.uses_pattern); diff --git a/src/legacy_canvas_stroke_execution_services.h b/src/legacy_canvas_stroke_execution_services.h index d5ab892..7193ab9 100644 --- a/src/legacy_canvas_stroke_execution_services.h +++ b/src/legacy_canvas_stroke_execution_services.h @@ -181,7 +181,6 @@ struct LegacyCanvasStrokeMixPassResult { struct LegacyCanvasStrokeDualPassRequest { std::string_view context; - std::span planes; std::function bind_brush_tip; std::function unbind_brush_tip; std::function setup_dual_shader;