From 5df2484c27292577262367d81cb54f97fc6754c4 Mon Sep 17 00:00:00 2001 From: omigamedev Date: Thu, 2 Feb 2017 22:52:06 +0000 Subject: [PATCH] fix a really bad bug using parent instead if this to set children's parent --- engine/layout.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/engine/layout.cpp b/engine/layout.cpp index 87bb1cc..3079201 100644 --- a/engine/layout.cpp +++ b/engine/layout.cpp @@ -205,8 +205,7 @@ void Node::load_internal(const tinyxml2::XMLElement* x_node) auto id = const_hash(ids); auto& ref = (*m_manager)[id]; m_children.push_back(ref.clone()); - m_children.back().parent = parent; - m_children.back().m_manager = m_manager; + m_children.back().parent = this; YGNodeInsertChild(y_node, m_children.back().y_node, YGNodeGetChildCount(y_node)); } else @@ -228,6 +227,7 @@ Node Node::clone() YGNodeCopyStyle(n.y_node, y_node); if (m_widget) n.m_widget = m_widget->clone(); + n.m_manager = m_manager; for (auto& c : m_children) { n.m_children.push_back(std::move(c.clone()));