omar/panopainter
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove legacy platform singleton accessor

Browse Source
This commit is contained in:
omigamedev
2026-06-17 11:59:19 +02:00
parent 30a07888da
commit 680452983f
5 changed files with 41 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
docs/modernization/tasks.md
View File

@@ -78,6 +78,17 @@ Completed, blocked, and superseded task history moved to
the queue is now ordered by code movement instead.
Current slice:
- `src/platform_legacy/legacy_platform_services.*` no longer exposes the dead
`pp::platform::legacy::platform_services()` singleton accessor.
- Linux, WebGL, and Android were already on owned
`create_platform_services(...)` instances, so removing that singleton does
not change the live entrypoint ownership path.
- `src/platform_windows/windows_runtime_state.*` now also owns the bound
Win32 `App*` / tablet binding surface alongside the retained owned `App`,
runtime, and tablet objects.
- `src/platform_windows/windows_runtime_shell.h` is thinner again and now
imports that binding surface from `windows_runtime_state.h` instead of
declaring shell-owned bind/release accessors itself.
- `src/platform_windows/windows_runtime_session.*` now owns the bound-session
Win32 runtime loop/startup/shutdown body.
- `src/platform_windows/windows_runtime_flow.cpp` is now only a thin handoff
@@ -198,8 +209,8 @@ Current slice:
`PlatformServices` instance in `android_main()`, replacing the direct bind to
the process-global fallback accessor.
- `src/platform_legacy/legacy_platform_services.*` now exposes an ownable
`create_platform_services()` entrypoint while keeping the fallback singleton
for non-migrated platforms.
`create_platform_services()` entrypoint for explicit per-entrypoint
ownership.
- `linux/src/main.cpp` now binds an owned legacy `PlatformServices` instance
into `App`, making Linux the first explicit per-entrypoint owner of that
legacy service implementation.
@@ -207,8 +218,8 @@ Current slice:
`pp::platform::legacy::platform_services()`; touched app platform dispatch
now expects an explicitly bound platform-services pointer.
- `linux/src/main.cpp`, `webgl/src/main.cpp`, and `android/src/cpp/main.cpp`
now bind `pp::platform::legacy::platform_services()` explicitly at app
creation, removing the hidden fallback path from live non-Windows entrypoints.
now bind owned `create_platform_services(...)` instances at app creation,
removing the hidden fallback path from live non-Windows entrypoints.
- `src/platform_windows/windows_runtime_shell.cpp` now owns the Windows tablet
object directly, removing the composition-edge `WacomTablet::I` binding from
the touched Windows runtime path.