From 779694ae1be093cd94decd6278c1ed2669608f16 Mon Sep 17 00:00:00 2001 From: omigamedev Date: Sat, 13 Jun 2026 17:55:27 +0200 Subject: [PATCH] Promote STR-006 dual stroke task --- docs/modernization/tasks.md | 32 ++++++++++++++++++++++++++++++-- 1 file changed, 30 insertions(+), 2 deletions(-) diff --git a/docs/modernization/tasks.md b/docs/modernization/tasks.md index d2e2457..f454423 100644 --- a/docs/modernization/tasks.md +++ b/docs/modernization/tasks.md @@ -810,8 +810,6 @@ Done Checks: | 2026-06-12 | ADP-001 | +1 legacy adapter retirement | `ctest --preset desktop-fast --build-config Debug -R "pp_app_core_document_resize\|pp_app_core_document_canvas\|pano_cli_plan_document_resize\|pano_cli_plan_canvas_clear" --output-on-failure`; `powershell -ExecutionPolicy Bypass -File scripts\automation\quiet-validate.ps1 -BuildTargets PanoPainter,pano_cli -TestRegex "pp_app_core\|pano_cli_plan"` | e489b1e2 | | 2026-06-12 | MT-001 | 0 | `git diff -- docs\modernization\roadmap.md docs\modernization\tasks.md` | same docs slice | | 2026-06-13 | STR-004 | +1 renderer boundary and OpenGL parity | `ctest --preset desktop-fast --build-config Debug -R "pp_paint_renderer_stroke_execution" --output-on-failure`; `MSBuild.exe out\build\windows-msvc-default\tests\pp_paint_renderer_stroke_execution_tests.vcxproj /p:Configuration=Debug /p:Platform=x64` | 5c03b130 | -| 2026-06-13 | STR-005 | +1 renderer boundary and OpenGL parity | `ctest --preset desktop-fast --build-config Debug -R "pp_paint_renderer_stroke_execution" --output-on-failure`; `MSBuild.exe out\build\windows-msvc-default\tests\pp_paint_renderer_stroke_execution_tests.vcxproj /p:Configuration=Debug /p:Platform=x64` | pending | - ## Task Template Use this shape when adding a new task: @@ -882,3 +880,33 @@ ctest --preset desktop-fast --build-config Debug -R "pp_paint_renderer_stroke_ex | Date | Task | Score | Validation | Commit | | --- | --- | ---: | --- | --- | | 2026-06-13 | STR-005 | +1 renderer boundary and OpenGL parity | `ctest --preset desktop-fast --build-config Debug -R "pp_paint_renderer_stroke_execution" --output-on-failure`; `MSBuild.exe out\build\windows-msvc-default\tests\pp_paint_renderer_stroke_execution_tests.vcxproj /p:Configuration=Debug /p:Platform=x64` | `4c9809f7` | + +### STR-006 - Extract Dual Stroke Face Execution Orchestration + +Status: Ready +Score: +1 renderer boundary and OpenGL parity +Debt: `DEBT-0036` +Scope: `src/canvas.cpp`, `src/legacy_canvas_stroke_execution_services.h`, +`tests/paint_renderer/stroke_execution_tests.cpp` + +Goal: + +Move the inline dual-stroke face execution lambda in `Canvas::stroke_draw()` +into a retained helper so the dual-pass branch keeps only concrete shader, +texture, and framebuffer wiring. Preserve dual-pass face order and callback +behavior. + +Done Checks: + +- `Canvas::stroke_draw()` no longer contains the inline dual-pass face execution + lambda around `execute_legacy_canvas_stroke_live_pass_with_face_framebuffers(...)`. +- Regression coverage proves the extracted helper preserves dual-pass callback + order and face execution. +- `docs/modernization/debt.md` records the reduced dual-pass callback surface. + +Validation: + +```powershell +ctest --preset desktop-fast --build-config Debug -R "pp_paint_renderer_stroke_execution" --output-on-failure +& 'C:\Program Files\Microsoft Visual Studio\18\Community\MSBuild\Current\Bin\MSBuild.exe' out\build\windows-msvc-default\tests\pp_paint_renderer_stroke_execution_tests.vcxproj /p:Configuration=Debug /p:Platform=x64 +```