Promote stroke draw dual pass frame callback task
This commit is contained in:
@@ -701,6 +701,34 @@ Validation:
|
|||||||
ctest --preset desktop-fast --build-config Debug -R "pp_paint_renderer_compositor|pp_paint_renderer_stroke_execution" --output-on-failure
|
ctest --preset desktop-fast --build-config Debug -R "pp_paint_renderer_compositor|pp_paint_renderer_stroke_execution" --output-on-failure
|
||||||
```
|
```
|
||||||
|
|
||||||
|
### STR-024 - Extract Stroke Draw Dual Pass Frame Callback Body
|
||||||
|
|
||||||
|
Status: Ready
|
||||||
|
Score: +1 renderer boundary and OpenGL parity
|
||||||
|
Debt: `DEBT-0036`
|
||||||
|
Scope: `src/canvas.cpp`, `src/legacy_canvas_stroke_execution_services.h`, `tests/paint_renderer/compositor_tests.cpp`
|
||||||
|
|
||||||
|
Goal:
|
||||||
|
|
||||||
|
Move the inline body passed to `execute_legacy_canvas_stroke_dual_pass_frame_callbacks(...)`
|
||||||
|
into a retained helper so the dual-pass branch owns only concrete callback
|
||||||
|
selection and framebuffer wiring.
|
||||||
|
|
||||||
|
Done Checks:
|
||||||
|
|
||||||
|
- `Canvas::stroke_draw()` no longer contains the inline dual-pass frame
|
||||||
|
callback body.
|
||||||
|
- Regression coverage proves the extracted helper preserves callback order and
|
||||||
|
face-state updates.
|
||||||
|
- `docs/modernization/debt.md` records the reduced dual-pass frame-callback
|
||||||
|
surface.
|
||||||
|
|
||||||
|
Validation:
|
||||||
|
|
||||||
|
```powershell
|
||||||
|
ctest --preset desktop-fast --build-config Debug -R "pp_paint_renderer_compositor|pp_paint_renderer_stroke_execution" --output-on-failure
|
||||||
|
```
|
||||||
|
|
||||||
Progress Notes:
|
Progress Notes:
|
||||||
|
|
||||||
- 2026-06-13: `NodeStrokePreview::draw_stroke_immediate()` now routes final
|
- 2026-06-13: `NodeStrokePreview::draw_stroke_immediate()` now routes final
|
||||||
|
|||||||
Reference in New Issue
Block a user