Remove generated fmt overlay

This commit is contained in:
2026-06-12 19:20:22 +02:00
parent 34a9e91099
commit 85d3fd5b93
4 changed files with 23 additions and 35 deletions

View File

@@ -319,31 +319,7 @@ if(PP_BUILD_APP)
target_include_directories(pp_legacy_vendor target_include_directories(pp_legacy_vendor
PUBLIC PUBLIC
${PP_LEGACY_INCLUDE_DIRS}) ${PP_LEGACY_INCLUDE_DIRS})
if(MSVC_VERSION GREATER_EQUAL 1945) file(REMOVE_RECURSE "${CMAKE_CURRENT_BINARY_DIR}/compat/fmt-vs2026")
set(PP_FMT_VS2026_COMPAT_INCLUDE_DIR
"${CMAKE_CURRENT_BINARY_DIR}/compat/fmt-vs2026/include")
set(PP_FMT_VS2026_COMPAT_FORMAT_H
"${PP_FMT_VS2026_COMPAT_INCLUDE_DIR}/fmt/format.h")
file(MAKE_DIRECTORY "${PP_FMT_VS2026_COMPAT_INCLUDE_DIR}")
file(COPY
"${CMAKE_CURRENT_SOURCE_DIR}/libs/fmt/include/fmt"
DESTINATION "${PP_FMT_VS2026_COMPAT_INCLUDE_DIR}")
file(READ
"${CMAKE_CURRENT_SOURCE_DIR}/libs/fmt/include/fmt/format.h"
PP_FMT_FORMAT_H)
# VS 2026 removed stdext::checked_array_iterator; keep the fmt
# submodule clean by disabling that legacy-only branch in the
# generated overlay.
string(REPLACE
"#ifdef _SECURE_SCL"
"#if 0"
PP_FMT_FORMAT_H
"${PP_FMT_FORMAT_H}")
file(WRITE "${PP_FMT_VS2026_COMPAT_FORMAT_H}" "${PP_FMT_FORMAT_H}")
target_include_directories(pp_legacy_vendor
BEFORE PRIVATE
"${PP_FMT_VS2026_COMPAT_INCLUDE_DIR}")
endif()
target_compile_definitions(pp_legacy_vendor target_compile_definitions(pp_legacy_vendor
PUBLIC PUBLIC
ENUM_BITFIELDS_NOT_SUPPORTED ENUM_BITFIELDS_NOT_SUPPORTED

File diff suppressed because one or more lines are too long

View File

@@ -31,14 +31,14 @@ auditable steps rather than by subjective estimates.
| Area | Weight | Current | Progress Rule | | Area | Weight | Current | Progress Rule |
| --- | ---: | ---: | --- | | --- | ---: | ---: | --- |
| Build and CMake ownership | 15 | 11 | Root CMake owns active source lists, app/tool targets, and retained package entrypoints. | | Build and CMake ownership | 15 | 12 | Root CMake owns active source lists, app/tool targets, and retained package entrypoints. |
| Test and automation coverage | 15 | 9 | Headless, platform, package, and focused validation commands exist and are current. | | Test and automation coverage | 15 | 9 | Headless, platform, package, and focused validation commands exist and are current. |
| Pure component behavior ownership | 15 | 8 | Behavior lives in `pp_*` components and is consumed by live adapters. | | Pure component behavior ownership | 15 | 8 | Behavior lives in `pp_*` components and is consumed by live adapters. |
| Legacy adapter retirement | 20 | 4 | `legacy_*_services` and singleton bridges are deleted or reduced to trivial composition. | | Legacy adapter retirement | 20 | 5 | `legacy_*_services` and singleton bridges are deleted or reduced to trivial composition. |
| Renderer boundary and OpenGL parity | 15 | 3 | Live render/export/readback paths execute through renderer interfaces with parity checks. | | Renderer boundary and OpenGL parity | 15 | 3 | Live render/export/readback paths execute through renderer interfaces with parity checks. |
| Platform and package parity | 10 | 4 | Required platforms have root CMake/package validation and injected platform services. | | Platform and package parity | 10 | 4 | Required platforms have root CMake/package validation and injected platform services. |
| Hardening and future backend readiness | 10 | 0 | Edge, fuzz, golden, stress, and backend-lab gates exist for high-risk paths. | | Hardening and future backend readiness | 10 | 0 | Edge, fuzz, golden, stress, and backend-lab gates exist for high-risk paths. |
| **Total** | **100** | **39** | Only completed tasks below may change this number. | | **Total** | **100** | **41** | Only completed tasks below may change this number. |
When updating `Current`, add a dated note under "Completed Task Log" with the When updating `Current`, add a dated note under "Completed Task Log" with the
task id, points moved, validation command, and commit hash. task id, points moved, validation command, and commit hash.
@@ -174,7 +174,7 @@ cmake --build --preset windows-msvc-default --config Debug --target PanoPainter
### ADP-004 - Make Dialog Creation A UI Factory Boundary ### ADP-004 - Make Dialog Creation A UI Factory Boundary
Status: Ready Status: Done
Score: +2 legacy adapter retirement Score: +2 legacy adapter retirement
Debt: `DEBT-0058`, `DEBT-0063` Debt: `DEBT-0058`, `DEBT-0063`
Scope: `src/legacy_app_dialog_services.*`, Scope: `src/legacy_app_dialog_services.*`,
@@ -206,7 +206,7 @@ cmake --build --preset windows-msvc-default --config Debug --target PanoPainter
### ADP-005 - Convert One Popup/Dialog Family To Checked Overlay Lifetime ### ADP-005 - Convert One Popup/Dialog Family To Checked Overlay Lifetime
Status: Ready Status: Done
Score: +2 legacy adapter retirement Score: +2 legacy adapter retirement
Debt: `DEBT-0063` Debt: `DEBT-0063`
Scope: choose exactly one family from `src/node_dialog_open.cpp`, Scope: choose exactly one family from `src/node_dialog_open.cpp`,
@@ -527,6 +527,8 @@ Done Checks:
| Date | Task | Score Change | Validation | Commit | | Date | Task | Score Change | Validation | Commit |
| --- | --- | ---: | --- | --- | | --- | --- | ---: | --- | --- |
| 2026-06-12 | DEP-001 | +1 build and CMake ownership | VS-bundled CMake build of `PanoPainter` and `pp_platform_api_tests`; `ctest --preset desktop-fast --build-config Debug -R pp_platform_api_tests --output-on-failure` | pending |
| 2026-06-12 | ADP-003 | +1 legacy adapter retirement | `ctest --preset desktop-fast --build-config Debug -R "pp_app_core_document_route\|pp_app_core_document_session\|pano_cli_plan_open_route\|pano_cli_simulate_app_session\|pano_cli_plan_document_file\|pano_cli_plan_document_version" --output-on-failure` | 34a9e910 |
| 2026-06-12 | PLT-002 | +2 platform and package parity | `ctest --preset desktop-fast --build-config Debug -R pp_platform_api_tests --output-on-failure`; `powershell -ExecutionPolicy Bypass -File scripts\automation\package-smoke.ps1 -ReadinessOnly`; `ctest --preset desktop-fast --build-config Debug -R "pp_app_core_document_layer\|pano_cli_plan_layer\|pp_platform_api_tests" --output-on-failure` | 8cd38401 | | 2026-06-12 | PLT-002 | +2 platform and package parity | `ctest --preset desktop-fast --build-config Debug -R pp_platform_api_tests --output-on-failure`; `powershell -ExecutionPolicy Bypass -File scripts\automation\package-smoke.ps1 -ReadinessOnly`; `ctest --preset desktop-fast --build-config Debug -R "pp_app_core_document_layer\|pano_cli_plan_layer\|pp_platform_api_tests" --output-on-failure` | 8cd38401 |
| 2026-06-12 | ADP-002 | +1 legacy adapter retirement | `ctest --preset desktop-fast --build-config Debug -R "pp_app_core_document_layer\|pano_cli_plan_layer" --output-on-failure`; `ctest --preset desktop-fast --build-config Debug -R "pp_app_core_document_layer\|pano_cli_plan_layer\|pp_platform_api_tests" --output-on-failure` | ae242852 | | 2026-06-12 | ADP-002 | +1 legacy adapter retirement | `ctest --preset desktop-fast --build-config Debug -R "pp_app_core_document_layer\|pano_cli_plan_layer" --output-on-failure`; `ctest --preset desktop-fast --build-config Debug -R "pp_app_core_document_layer\|pano_cli_plan_layer\|pp_platform_api_tests" --output-on-failure` | ae242852 |
| 2026-06-12 | ADP-001 | +1 legacy adapter retirement | `ctest --preset desktop-fast --build-config Debug -R "pp_app_core_document_resize\|pp_app_core_document_canvas\|pano_cli_plan_document_resize\|pano_cli_plan_canvas_clear" --output-on-failure`; `powershell -ExecutionPolicy Bypass -File scripts\automation\quiet-validate.ps1 -BuildTargets PanoPainter,pano_cli -TestRegex "pp_app_core\|pano_cli_plan"` | e489b1e2 | | 2026-06-12 | ADP-001 | +1 legacy adapter retirement | `ctest --preset desktop-fast --build-config Debug -R "pp_app_core_document_resize\|pp_app_core_document_canvas\|pano_cli_plan_document_resize\|pano_cli_plan_canvas_clear" --output-on-failure`; `powershell -ExecutionPolicy Bypass -File scripts\automation\quiet-validate.ps1 -BuildTargets PanoPainter,pano_cli -TestRegex "pp_app_core\|pano_cli_plan"` | e489b1e2 |