omar/panopainter
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Extract quick UI operation planning

Browse Source
This commit is contained in:
omigamedev
2026-06-03 11:01:01 +02:00
parent 73fac0f8e4
commit 8dc476d205
8 changed files with 499 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
tests/CMakeLists.txt
View File

@@ -288,6 +288,16 @@ add_test(NAME pp_app_core_grid_ui_tests COMMAND pp_app_core_grid_ui_tests)
set_tests_properties(pp_app_core_grid_ui_tests PROPERTIES
LABELS "app;ui;renderer;desktop-fast;fuzz")
add_executable(pp_app_core_quick_ui_tests
app_core/quick_ui_tests.cpp)
target_link_libraries(pp_app_core_quick_ui_tests PRIVATE
pp_app_core
pp_test_harness)
add_test(NAME pp_app_core_quick_ui_tests COMMAND pp_app_core_quick_ui_tests)
set_tests_properties(pp_app_core_quick_ui_tests PROPERTIES
LABELS "app;ui;paint;desktop-fast;fuzz")
add_executable(pp_app_core_document_route_tests
app_core/document_route_tests.cpp)
target_link_libraries(pp_app_core_document_route_tests PRIVATE
@@ -862,6 +872,42 @@ if(TARGET pano_cli)
LABELS "app;ui;renderer;integration;desktop-fast;fuzz"
WILL_FAIL TRUE)
add_test(NAME pano_cli_plan_quick_operation_select_brush_smoke
COMMAND pano_cli plan-quick-operation --kind brush --current-index 0 --slot-index 2)
set_tests_properties(pano_cli_plan_quick_operation_select_brush_smoke PROPERTIES
LABELS "app;ui;paint;integration;desktop-fast"
PASS_REGULAR_EXPRESSION "\"command\":\"plan-quick-operation\".*\"operation\":\"select-slot\".*\"slotKind\":\"brush\".*\"slotIndex\":2.*\"updatesSelection\":true.*\"invokesChangeCallback\":true")
add_test(NAME pano_cli_plan_quick_operation_open_color_smoke
COMMAND pano_cli plan-quick-operation --kind color --current-index 1 --slot-index 1)
set_tests_properties(pano_cli_plan_quick_operation_open_color_smoke PROPERTIES
LABELS "app;ui;paint;integration;desktop-fast"
PASS_REGULAR_EXPRESSION "\"command\":\"plan-quick-operation\".*\"operation\":\"open-slot-popup\".*\"slotKind\":\"color\".*\"opensColorPicker\":true.*\"mutatesQuickState\":false")
add_test(NAME pano_cli_plan_quick_operation_restore_smoke
COMMAND pano_cli plan-quick-operation --kind restore --brush-index 2 --color-index 1 --fire-event)
set_tests_properties(pano_cli_plan_quick_operation_restore_smoke PROPERTIES
LABELS "app;ui;paint;integration;desktop-fast"
PASS_REGULAR_EXPRESSION "\"command\":\"plan-quick-operation\".*\"operation\":\"restore-state\".*\"fireEvent\":true.*\"invokesChangeCallback\":true.*\"restoresSlots\":true.*\"redrawsBrushPreviews\":true")
add_test(NAME pano_cli_plan_quick_operation_reset_smoke
COMMAND pano_cli plan-quick-operation --kind reset)
set_tests_properties(pano_cli_plan_quick_operation_reset_smoke PROPERTIES
LABELS "app;ui;paint;integration;desktop-fast"
PASS_REGULAR_EXPRESSION "\"command\":\"plan-quick-operation\".*\"operation\":\"reset-state\".*\"invokesChangeCallback\":false.*\"resetsSlots\":true.*\"redrawsBrushPreviews\":true")
add_test(NAME pano_cli_plan_quick_operation_rejects_bad_slot
COMMAND pano_cli plan-quick-operation --kind brush --current-index 0 --slot-index 3)
set_tests_properties(pano_cli_plan_quick_operation_rejects_bad_slot PROPERTIES
LABELS "app;ui;paint;integration;desktop-fast;fuzz"
WILL_FAIL TRUE)
add_test(NAME pano_cli_plan_quick_operation_rejects_bad_restore
COMMAND pano_cli plan-quick-operation --kind restore --brush-index -1 --color-index 0)
set_tests_properties(pano_cli_plan_quick_operation_rejects_bad_restore PROPERTIES
LABELS "app;ui;paint;integration;desktop-fast;fuzz"
WILL_FAIL TRUE)
add_test(NAME pano_cli_plan_share_file_unsaved_smoke
COMMAND pano_cli plan-share-file)
set_tests_properties(pano_cli_plan_share_file_unsaved_smoke PROPERTIES

83
tests/app_core/quick_ui_tests.cpp Normal file
View File

@@ -0,0 +1,83 @@
#include "app_core/quick_ui.h"
#include "test_harness.h"
namespace {
void slot_click_selects_or_opens_popup(pp::tests::Harness& harness)
{
const auto select_brush = pp::app::plan_quick_slot_click(pp::app::QuickUiSlotKind::brush, 0, 2, 3);
PP_EXPECT(harness, select_brush);
if (select_brush) {
PP_EXPECT(harness, select_brush.value().operation == pp::app::QuickUiOperation::select_slot);
PP_EXPECT(harness, select_brush.value().slot_kind == pp::app::QuickUiSlotKind::brush);
PP_EXPECT(harness, select_brush.value().slot_index == 2);
PP_EXPECT(harness, select_brush.value().previous_index == 0);
PP_EXPECT(harness, select_brush.value().updates_selection);
PP_EXPECT(harness, select_brush.value().invokes_change_callback);
PP_EXPECT(harness, select_brush.value().mutates_quick_state);
PP_EXPECT(harness, !select_brush.value().opens_brush_popup);
}
const auto open_brush = pp::app::plan_quick_slot_click(pp::app::QuickUiSlotKind::brush, 1, 1, 3);
PP_EXPECT(harness, open_brush);
if (open_brush) {
PP_EXPECT(harness, open_brush.value().operation == pp::app::QuickUiOperation::open_slot_popup);
PP_EXPECT(harness, open_brush.value().opens_brush_popup);
PP_EXPECT(harness, !open_brush.value().opens_color_picker);
PP_EXPECT(harness, !open_brush.value().updates_selection);
PP_EXPECT(harness, !open_brush.value().mutates_quick_state);
}
const auto open_color = pp::app::plan_quick_slot_click(pp::app::QuickUiSlotKind::color, 0, 0, 3);
PP_EXPECT(harness, open_color);
if (open_color) {
PP_EXPECT(harness, open_color.value().opens_color_picker);
PP_EXPECT(harness, !open_color.value().opens_brush_popup);
}
}
void slot_click_rejects_invalid_indices(pp::tests::Harness& harness)
{
PP_EXPECT(harness, !pp::app::plan_quick_slot_click(pp::app::QuickUiSlotKind::brush, -1, 0, 3));
PP_EXPECT(harness, !pp::app::plan_quick_slot_click(pp::app::QuickUiSlotKind::brush, 0, 3, 3));
PP_EXPECT(harness, !pp::app::plan_quick_slot_click(pp::app::QuickUiSlotKind::color, 0, 0, 0));
}
void restore_and_reset_validate_state(pp::tests::Harness& harness)
{
const auto restore = pp::app::plan_quick_state_restore(2, 1, 3, true);
PP_EXPECT(harness, restore);
if (restore) {
PP_EXPECT(harness, restore.value().operation == pp::app::QuickUiOperation::restore_state);
PP_EXPECT(harness, restore.value().slot_count == 3);
PP_EXPECT(harness, restore.value().fire_event);
PP_EXPECT(harness, restore.value().restores_slots);
PP_EXPECT(harness, restore.value().redraws_brush_previews);
PP_EXPECT(harness, restore.value().invokes_change_callback);
}
const auto reset = pp::app::plan_quick_state_reset(3, false);
PP_EXPECT(harness, reset);
if (reset) {
PP_EXPECT(harness, reset.value().operation == pp::app::QuickUiOperation::reset_state);
PP_EXPECT(harness, reset.value().resets_slots);
PP_EXPECT(harness, reset.value().redraws_brush_previews);
PP_EXPECT(harness, !reset.value().invokes_change_callback);
PP_EXPECT(harness, reset.value().mutates_quick_state);
}
PP_EXPECT(harness, !pp::app::plan_quick_state_restore(3, 0, 3, false));
PP_EXPECT(harness, !pp::app::plan_quick_state_restore(0, -1, 3, false));
PP_EXPECT(harness, !pp::app::plan_quick_state_reset(0, false));
}
} // namespace
int main()
{
pp::tests::Harness harness;
harness.run("slot click selects or opens popup", slot_click_selects_or_opens_popup);
harness.run("slot click rejects invalid indices", slot_click_rejects_invalid_indices);
harness.run("restore and reset validate state", restore_and_reset_validate_state);
return harness.finish();
}