Hide startup preference keys behind adapter

src/app.cpp

@@ -426,10 +426,12 @@ void App::init()
             LOG("OpenGL startup state failed: %s", startup_state_status.message);
     });
 
+    const auto startup_preferences =
+        pp::panopainter::read_legacy_startup_preferences(vr_controllers_enabled);
     const auto startup_plan = pp::app::plan_app_startup(
-        pp::panopainter::legacy_integer_preference("run_counter"),
-        pp::panopainter::legacy_boolean_preference_or("auto-timelapse", true),
-        pp::panopainter::legacy_boolean_preference_or("vr-controllers-enabled", vr_controllers_enabled),
+        startup_preferences.run_counter,
+        startup_preferences.auto_timelapse,
+        startup_preferences.vr_controllers_enabled,
         check_license());
     if (!startup_plan) {
         LOG("App startup plan failed: %s", startup_plan.status().message);

src/legacy_preference_storage.cpp

@@ -12,6 +12,15 @@ bool load_legacy_preferences()
     return Settings::load();
 }
 
+LegacyStartupPreferenceSnapshot read_legacy_startup_preferences(bool default_vr_controllers_enabled)
+{
+    return {
+        Settings::value<Serializer::Integer>("run_counter"),
+        Settings::value_or<Serializer::Boolean>("auto-timelapse", true),
+        Settings::value_or<Serializer::Boolean>("vr-controllers-enabled", default_vr_controllers_enabled),
+    };
+}
+
 bool has_legacy_preference(const char* key)
 {
     return Settings::has(key);

src/legacy_preference_storage.h

@@ -4,7 +4,14 @@
 
 namespace pp::panopainter {
 
+struct LegacyStartupPreferenceSnapshot {
+    int run_counter = 0;
+    bool auto_timelapse = true;
+    bool vr_controllers_enabled = true;
+};
+
 bool load_legacy_preferences();
+LegacyStartupPreferenceSnapshot read_legacy_startup_preferences(bool default_vr_controllers_enabled);
 bool has_legacy_preference(const char* key);
 int legacy_integer_preference(const char* key);
 int legacy_integer_preference_or(const char* key, int default_value);