From a401ab356b1158c2f640c2a7922926e744a5e5b0 Mon Sep 17 00:00:00 2001 From: omigamedev Date: Mon, 15 Jun 2026 22:31:43 +0200 Subject: [PATCH] Record document open unsaved prompt closeout --- docs/modernization/debt.md | 6 ++++++ docs/modernization/roadmap.md | 5 +++++ docs/modernization/tasks.md | 36 +++++++++++++++++++++++++++++++++++ 3 files changed, 47 insertions(+) diff --git a/docs/modernization/debt.md b/docs/modernization/debt.md index 3d9f7c41..89dca492 100644 --- a/docs/modernization/debt.md +++ b/docs/modernization/debt.md @@ -64,6 +64,12 @@ agent or engineer to remove them without reconstructing context from chat. dialog method; the remaining document-open bridge debt stays concentrated in unsaved-project prompts, project-open execution, layer refresh, title updates, and retained history services. +- 2026-06-15: `DEBT-0039` was narrowed again. The retained unsaved-project + discard prompt wiring in `LegacyDocumentOpenServices::prompt_discard_unsaved_project()` + now routes through a focused helper in `src/legacy_document_open_services.cpp` + instead of living inline in the retained document-open service method; the + remaining document-open bridge debt stays concentrated in project-open + execution, layer refresh, title updates, and retained history services. - 2026-06-15: `DEBT-0038` was narrowed again. The retained cloud downloaded- project open camera reset and layer-clear setup in `execute_legacy_downloaded_project_open()` now routes through a focused diff --git a/docs/modernization/roadmap.md b/docs/modernization/roadmap.md index 7a580e73..c4a8c949 100644 --- a/docs/modernization/roadmap.md +++ b/docs/modernization/roadmap.md @@ -1395,6 +1395,11 @@ The retained document-browse button wiring in `App::dialog_browse()` now also routes through a focused helper, so the remaining document-open bridge debt is further concentrated on unsaved-project prompts, project-open execution, layer refresh, title updates, and retained history services. +The retained unsaved-project discard prompt wiring in +`LegacyDocumentOpenServices::prompt_discard_unsaved_project()` now also routes +through a focused helper, so the remaining document-open bridge debt is +further concentrated on project-open execution, layer refresh, title updates, +and retained history services. `App::request_close`, `App::save_document`, and `App::continue_document_workflow_after_optional_save` now route through app-core document-session executors and `src/legacy_document_session_services.*`, diff --git a/docs/modernization/tasks.md b/docs/modernization/tasks.md index 4bdbe486..40bb7a8e 100644 --- a/docs/modernization/tasks.md +++ b/docs/modernization/tasks.md @@ -1667,6 +1667,42 @@ Completed Task Log: | --- | --- | ---: | --- | --- | | 2026-06-15 | ADP-044 | no score movement | `powershell -ExecutionPolicy Bypass -File scripts\\automation\\quiet-validate.ps1 -BuildTargets pano_cli -TestRegex "pp_app_core_document_session|pano_cli_plan_document_session_prompt"` | `294d9ce7` | +### ADP-045 - Extract Document-Open Unsaved Prompt Helper + +Status: Done +Score: no score movement +Debt: `DEBT-0039` +Scope: `src/legacy_document_open_services.cpp` only + +Closeout: `39728e46` + +Goal: + +Reduce the inline retained unsaved-project discard prompt surface by +extracting the button wiring from `LegacyDocumentOpenServices::prompt_discard_unsaved_project()` +into a focused helper while preserving current behavior. + +Done Checks: + +- The retained unsaved-project discard prompt wiring no longer lives inline in + `LegacyDocumentOpenServices::prompt_discard_unsaved_project()`. +- The retained unsaved-project discard prompt path now routes through a focused + helper in `src/legacy_document_open_services.cpp`. +- `DEBT-0039` and the roadmap note the reduced remaining document-open bridge + surface. + +Validation: + +```powershell +powershell -ExecutionPolicy Bypass -File scripts\\automation\\quiet-validate.ps1 -BuildTargets pano_cli -TestRegex "pp_app_core_document_route|pp_app_core_document_session" +``` + +Completed Task Log: + +| Date | Task | Score | Validation | Commit | +| --- | --- | ---: | --- | --- | +| 2026-06-15 | ADP-045 | no score movement | `powershell -ExecutionPolicy Bypass -File scripts\\automation\\quiet-validate.ps1 -BuildTargets pano_cli -TestRegex "pp_app_core_document_route|pp_app_core_document_session"` | `39728e46` | + ### RND-001 - Make Pure Equirectangular Export The Primary Success Path Status: Done