Add canvas clear service boundary

src/app_core/document_canvas.h

@@ -17,6 +17,13 @@ struct DocumentCanvasClearPlan {
     bool no_op = true;
 };
 
+class DocumentCanvasClearServices {
+public:
+    virtual ~DocumentCanvasClearServices() = default;
+
+    virtual void clear_current_canvas(float r, float g, float b, float a) = 0;
+};
+
 [[nodiscard]] inline pp::foundation::Status validate_clear_color_channel(float value) noexcept
 {
     if (!std::isfinite(value)) {
@@ -55,4 +62,24 @@ struct DocumentCanvasClearPlan {
     return pp::foundation::Result<DocumentCanvasClearPlan>::success(plan);
 }
 
+[[nodiscard]] inline pp::foundation::Status execute_document_canvas_clear_plan(
+    const DocumentCanvasClearPlan& plan,
+    DocumentCanvasClearServices& services)
+{
+    const float channels[] { plan.r, plan.g, plan.b, plan.a };
+    for (const float channel : channels) {
+        const auto status = validate_clear_color_channel(channel);
+        if (!status.ok()) {
+            return status;
+        }
+    }
+
+    if (plan.no_op || !plan.clears_canvas) {
+        return pp::foundation::Status::success();
+    }
+
+    services.clear_current_canvas(plan.r, plan.g, plan.b, plan.a);
+    return pp::foundation::Status::success();
+}
+
 } // namespace pp::app

src/app_core/main_toolbar.h

@@ -41,6 +41,7 @@ struct MainToolbarPlan {
     bool records_undo = false;
     bool marks_unsaved = false;
     bool no_op = false;
+    DocumentCanvasClearPlan canvas_clear;
 };
 
 class MainToolbarServices {
@@ -52,7 +53,7 @@ public:
     virtual void invoke_undo() = 0;
     virtual void invoke_redo() = 0;
     virtual void clear_history() = 0;
-    virtual void clear_canvas() = 0;
+    virtual void clear_canvas(const DocumentCanvasClearPlan& plan) = 0;
     virtual void show_message_box() = 0;
     virtual void show_settings_dialog() = 0;
 };
@@ -139,6 +140,7 @@ public:
         plan.records_undo = clear.value().records_undo;
         plan.marks_unsaved = clear.value().marks_unsaved;
         plan.no_op = clear.value().no_op;
+        plan.canvas_clear = clear.value();
         return pp::foundation::Result<MainToolbarPlan>::success(plan);
     }
 
@@ -178,7 +180,7 @@ public:
         services.clear_history();
         return pp::foundation::Status::success();
     case MainToolbarAction::clear_canvas:
-        services.clear_canvas();
+        services.clear_canvas(plan.canvas_clear);
         return pp::foundation::Status::success();
     case MainToolbarAction::show_message_box:
         services.show_message_box();

src/app_layout.cpp

@@ -305,12 +305,31 @@ public:
         ActionManager::clear();
     }
 
-    void clear_canvas() override
+    void clear_canvas(const pp::app::DocumentCanvasClearPlan& plan) override
     {
-        if (!app_.canvas || !app_.canvas->m_canvas)
-            return;
+        class LegacyDocumentCanvasClearServices final : public pp::app::DocumentCanvasClearServices {
+        public:
+            explicit LegacyDocumentCanvasClearServices(App& app) noexcept
+                : app_(app)
+            {
+            }
 
-        app_.canvas->m_canvas->clear({ 0.0F, 0.0F, 0.0F, 0.0F });
+            void clear_current_canvas(float r, float g, float b, float a) override
+            {
+                if (!app_.canvas || !app_.canvas->m_canvas)
+                    return;
+
+                app_.canvas->m_canvas->clear({ r, g, b, a });
+            }
+
+        private:
+            App& app_;
+        };
+
+        LegacyDocumentCanvasClearServices services(app_);
+        const auto status = pp::app::execute_document_canvas_clear_plan(plan, services);
+        if (!status.ok())
+            LOG("Canvas clear failed: %s", status.message);
     }
 
     void show_message_box() override