Centralize retained service dialog closing
This commit is contained in:
@@ -541,6 +541,9 @@ agent or engineer to remove them without reconstructing context from chat.
|
|||||||
- 2026-06-12: DEBT-0063/DEBT-0058 were narrowed again. Cloud publish prompts,
|
- 2026-06-12: DEBT-0063/DEBT-0058 were narrowed again. Cloud publish prompts,
|
||||||
upload/download progress dialogs, and cloud browser download-close now route
|
upload/download progress dialogs, and cloud browser download-close now route
|
||||||
retained closing through `src/legacy_ui_overlay_services.*`.
|
retained closing through `src/legacy_ui_overlay_services.*`.
|
||||||
|
- 2026-06-12: DEBT-0063/DEBT-0058 were narrowed again. App message-dialog
|
||||||
|
cancel-button removal, layer-rename finish cleanup, and recording export
|
||||||
|
progress cleanup now route retained closing through `src/legacy_ui_overlay_services.*`.
|
||||||
- 2026-06-05: DEBT-0011 was narrowed. The Windows app package smoke target now
|
- 2026-06-05: DEBT-0011 was narrowed. The Windows app package smoke target now
|
||||||
passes the configure-time CMake executable into `package-smoke.ps1`, so VS
|
passes the configure-time CMake executable into `package-smoke.ps1`, so VS
|
||||||
2026 generator validation does not depend on an older `cmake` on PATH, and
|
2026 generator validation does not depend on an older `cmake` on PATH, and
|
||||||
|
|||||||
@@ -513,6 +513,8 @@ new/save document cleanup now route retained dialog closing through the same
|
|||||||
helpers.
|
helpers.
|
||||||
Cloud publish prompts, upload/download progress dialogs, and cloud browser
|
Cloud publish prompts, upload/download progress dialogs, and cloud browser
|
||||||
download-close now use the retained overlay close helpers.
|
download-close now use the retained overlay close helpers.
|
||||||
|
App message-dialog cancel-button removal, layer-rename finish cleanup, and
|
||||||
|
recording export progress cleanup also route through those helpers.
|
||||||
Raw popup callback captures and full close/capture ownership remain part of
|
Raw popup callback captures and full close/capture ownership remain part of
|
||||||
`DEBT-0063`.
|
`DEBT-0063`.
|
||||||
`pano_cli inspect-image` exposes PNG IHDR metadata as JSON,
|
`pano_cli inspect-image` exposes PNG IHDR metadata as JSON,
|
||||||
|
|||||||
@@ -33,7 +33,7 @@ std::shared_ptr<NodeMessageBox> create_legacy_app_message_dialog(
|
|||||||
if (plan.show_cancel)
|
if (plan.show_cancel)
|
||||||
message->btn_cancel->m_text->set_text(plan.cancel_caption.c_str());
|
message->btn_cancel->m_text->set_text(plan.cancel_caption.c_str());
|
||||||
else
|
else
|
||||||
message->btn_cancel->destroy();
|
close_legacy_dialog_node(*message->btn_cancel);
|
||||||
(void)attach_legacy_overlay_node(app, message);
|
(void)attach_legacy_overlay_node(app, message);
|
||||||
return message;
|
return message;
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -5,6 +5,7 @@
|
|||||||
#include "action.h"
|
#include "action.h"
|
||||||
#include "app.h"
|
#include "app.h"
|
||||||
#include "legacy_document_canvas_services.h"
|
#include "legacy_document_canvas_services.h"
|
||||||
|
#include "legacy_ui_overlay_services.h"
|
||||||
|
|
||||||
namespace pp::panopainter {
|
namespace pp::panopainter {
|
||||||
namespace {
|
namespace {
|
||||||
@@ -71,7 +72,7 @@ public:
|
|||||||
void finish_layer_rename() override
|
void finish_layer_rename() override
|
||||||
{
|
{
|
||||||
if (dialog_)
|
if (dialog_)
|
||||||
dialog_->destroy();
|
pp::panopainter::close_legacy_dialog_node(*dialog_);
|
||||||
app_.hideKeyboard();
|
app_.hideKeyboard();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -5,6 +5,7 @@
|
|||||||
#include "app.h"
|
#include "app.h"
|
||||||
#include "canvas.h"
|
#include "canvas.h"
|
||||||
#include "legacy_app_dialog_services.h"
|
#include "legacy_app_dialog_services.h"
|
||||||
|
#include "legacy_ui_overlay_services.h"
|
||||||
#include "node_progress_bar.h"
|
#include "node_progress_bar.h"
|
||||||
|
|
||||||
namespace pp::panopainter {
|
namespace pp::panopainter {
|
||||||
@@ -64,7 +65,7 @@ public:
|
|||||||
void end_export() override
|
void end_export() override
|
||||||
{
|
{
|
||||||
if (progress_)
|
if (progress_)
|
||||||
progress_->destroy();
|
pp::panopainter::close_legacy_dialog_node(*progress_);
|
||||||
progress_ = nullptr;
|
progress_ = nullptr;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user