Move Win32 VR state behind platform services

docs/modernization/roadmap.md

@@ -70,6 +70,10 @@ What is already real:
 - `pp_app_core`
 
 Latest slice:
+- `src/platform_windows/windows_platform_services.cpp` now owns the retained
+  Win32 VR shell state directly behind `platform_vr_state()`.
+- `src/platform_windows/windows_window_shell.cpp` no longer exposes or owns a
+  separate `retained_vr_shell_state()` pocket.
 - `src/platform_windows/windows_lifecycle_state.*` now owns the retained
   Win32 lifecycle running flag and FPS-title scratch buffer instead of leaving
   them inside `windows_lifecycle_shell.cpp`.

docs/modernization/tasks.md

@@ -78,6 +78,10 @@ Completed, blocked, and superseded task history moved to
   the queue is now ordered by code movement instead.
 
 Current slice:
+- `src/platform_windows/windows_platform_services.cpp` now owns the retained
+  Win32 VR shell state directly behind `platform_vr_state()`.
+- `src/platform_windows/windows_window_shell.cpp` no longer keeps a separate
+  retained VR shell-state accessor.
 - `src/platform_windows/windows_lifecycle_state.*` now owns the retained
   Win32 lifecycle running flag and FPS-title scratch buffer.
 - `src/platform_windows/windows_lifecycle_shell.cpp` no longer carries that

src/platform_windows/windows_platform_services.cpp

@@ -20,10 +20,6 @@
 #include <deque>
 #include <map>
 
-namespace pp::platform::windows {
-[[nodiscard]] VrShellState& platform_vr_state() noexcept;
-}
-
 void destroy_window();
 void async_lock();
 void async_unlock();
@@ -134,7 +130,8 @@ void initialize_retained_input_state()
 
 VrShellState& platform_vr_state() noexcept
 {
-    return retained_vr_shell_state();
+    static VrShellState state;
+    return state;
 }
 
 }

src/platform_windows/windows_platform_services.h

@@ -5,10 +5,12 @@
 #include <future>
 
 struct VrSessionSnapshot;
+struct VrShellState;
 
 namespace pp::platform::windows {
 
 [[nodiscard]] PlatformServices& platform_services();
+[[nodiscard]] VrShellState& platform_vr_state() noexcept;
 [[nodiscard]] VrSessionSnapshot read_platform_vr_session_snapshot() noexcept;
 void enqueue_main_thread_task(std::packaged_task<void()> task);
 void drain_main_thread_tasks();

src/platform_windows/windows_window_shell.cpp

@@ -60,12 +60,6 @@ void synchronize_app_key_state_from_keyboard(App& app)
 
 }
 
-pp::platform::windows::VrShellState& pp::platform::windows::retained_vr_shell_state() noexcept
-{
-    static pp::platform::windows::VrShellState state;
-    return state;
-}
-
 LRESULT CALLBACK main_window_proc(HWND hWnd, UINT msg, WPARAM wp, LPARAM lp)
 {
     auto* app = bound_app();
@@ -75,7 +69,7 @@ LRESULT CALLBACK main_window_proc(HWND hWnd, UINT msg, WPARAM wp, LPARAM lp)
     switch (msg)
     {
     case kUserCloseMessage:
-        handle_window_close_message(retained_vr_shell_state());
+        handle_window_close_message(pp::platform::windows::platform_vr_state());
         return 0;
     case WM_PAINT:
         app->redraw = true;

src/platform_windows/windows_window_shell.h

@@ -3,12 +3,10 @@
 #include <Windows.h>
 
 #include "event.h"
-#include "platform_windows/windows_vr_shell.h"
 
 namespace pp::platform::windows {
 
 void initialize_retained_input_state();
-pp::platform::windows::VrShellState& retained_vr_shell_state() noexcept;
 LRESULT CALLBACK main_window_proc(HWND hWnd, UINT msg, WPARAM wp, LPARAM lp);
 
 }