omar/panopainter
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Extract document-session close prompt helper

Browse Source
This commit is contained in:
omigamedev
2026-06-15 22:09:49 +02:00
parent f6afd34256
commit be8dee8de5
4 changed files with 63 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
docs/modernization/debt.md
View File

@@ -18,6 +18,12 @@ agent or engineer to remove them without reconstructing context from chat.
## Recent Reductions
- 2026-06-15: `DEBT-0040` was narrowed again. The retained close-unsaved
prompt wiring in `src/legacy_document_session_services.cpp` now routes
through a focused helper instead of living inline in
`show_unsaved_close_prompt()`; the remaining document-session bridge debt
stays concentrated in save-before-workflow prompts, save-version routing,
app document field mutation, and keyboard/dialog cleanup.
- 2026-06-15: `DEBT-0040` was narrowed again. The retained save-before-
continue workflow prompt wiring in `src/legacy_document_session_services.cpp`
now routes through a focused helper instead of living inline in

5
docs/modernization/roadmap.md
View File

@@ -1415,6 +1415,11 @@ The retained save-before-continue workflow prompt wiring in
helper, so the remaining document-session bridge debt is further concentrated
on close prompts, native close requests, save-version routing, app document
field mutation, and keyboard/dialog cleanup.
The retained close-unsaved prompt wiring in
`src/legacy_document_session_services.*` now also routes through a focused
helper, so the remaining document-session bridge debt is further concentrated
on save-before-workflow prompts, save-version routing, app document field
mutation, and keyboard/dialog cleanup.
`App::dialog_newdoc` now routes accepted new-document plans through the
app-core new-document executor and `src/legacy_document_session_services.*`,
preserving target overwrite prompts, legacy canvas resize/layer setup, history

36
docs/modernization/tasks.md
View File

@@ -1488,6 +1488,42 @@ Completed Task Log:
| --- | --- | ---: | --- | --- |
| 2026-06-15 | ADP-039 | no score movement | `powershell -ExecutionPolicy Bypass -File scripts\\automation\\quiet-validate.ps1 -BuildTargets pano_cli,pp_app_core_document_session_tests -TestRegex "pp_app_core_document_session|pano_cli_plan_document_session_prompt"` | `c37451e9` |
### ADP-040 - Extract Document-Session Close Prompt Helper
Status: Done
Score: no score movement
Debt: `DEBT-0040`
Scope: `src/legacy_document_session_services.cpp` only
Closeout: `c37451e9`
Goal:
Reduce the inline retained close-unsaved prompt surface by extracting the
button wiring from `show_unsaved_close_prompt()` into a focused helper while
preserving current behavior.
Done Checks:
- The retained close-unsaved prompt wiring no longer lives inline in
`show_unsaved_close_prompt()`.
- The retained close prompt path now routes through a focused helper in
`src/legacy_document_session_services.cpp`.
- `DEBT-0040` and the roadmap note the reduced remaining document-session
bridge surface.
Validation:
```powershell
powershell -ExecutionPolicy Bypass -File scripts\\automation\\quiet-validate.ps1 -BuildTargets pano_cli,pp_app_core_document_session_tests -TestRegex "pp_app_core_document_session|pano_cli_plan_document_session_prompt"
```
Completed Task Log:
| Date | Task | Score | Validation | Commit |
| --- | --- | ---: | --- | --- |
| 2026-06-15 | ADP-040 | no score movement | `powershell -ExecutionPolicy Bypass -File scripts\\automation\\quiet-validate.ps1 -BuildTargets pano_cli,pp_app_core_document_session_tests -TestRegex "pp_app_core_document_session|pano_cli_plan_document_session_prompt"` | `c37451e9` |
### RND-001 - Make Pure Equirectangular Export The Primary Success Path
Status: Done