Centralize legacy video export bridge
This commit is contained in:
@@ -563,7 +563,8 @@ Known local toolchain state:
|
||||
invalid export naming inputs, plus export-start license/canvas availability
|
||||
decisions, export menu executor dispatch, file/stem/collection export
|
||||
execution dispatch, failed directory creation preservation, named depth/cube
|
||||
export dispatch, and malformed export target rejection.
|
||||
export dispatch, malformed export target rejection, video export dispatch for
|
||||
animation MP4/timelapse paths, and empty video-path rejection.
|
||||
- `pp_app_core_document_recording_tests` covers recording start/stop, clear,
|
||||
platform recorded-file cleanup, frame-count reset, export progress totals,
|
||||
and oversized progress-total clamping.
|
||||
@@ -612,7 +613,11 @@ Known local toolchain state:
|
||||
layers, animation-frame, depth, and cube-face export calls. It preserves
|
||||
platform-specific export messages, directory creation, picker-selected stem
|
||||
exports, Web prepared-file handoff, and legacy `Canvas` export execution while
|
||||
retained renderer/document/platform ownership is tracked by `DEBT-0043`.
|
||||
retained renderer/document/platform ownership is tracked by `DEBT-0043`. It
|
||||
also bridges timelapse and animation MP4 export picker-selected paths while
|
||||
preserving desktop worker-thread timelapse behavior, mobile/Web save
|
||||
callbacks, `App::rec_export`, animation `Canvas::export_anim_mp4`, and
|
||||
success messages; retained video/export ownership is tracked by `DEBT-0044`.
|
||||
- `src/legacy_history_services.*` is the current app-shell bridge between
|
||||
`pp_app_core` history plans and legacy `ActionManager`; toolbar and
|
||||
`NodeCanvas` hotkeys share it while document-history extraction remains
|
||||
|
||||
@@ -61,6 +61,7 @@ agent or engineer to remove them without reconstructing context from chat.
|
||||
| DEBT-0041 | Open | Modernization | Accepted new-document planning/execution dispatch now consumes pure `pp_app_core` through `App::dialog_newdoc`, `pano_cli plan-new-document`, `NewDocumentServices`, and `src/legacy_document_session_services.*`, but the bridge still mutates legacy app document fields, clears legacy layer UI, resizes legacy `Canvas`, clears legacy history, creates the default layer through legacy UI, mutates unsaved/new-document flags, updates the title, and handles keyboard/dialog cleanup directly | Preserve current New Document dialog behavior while document creation moves toward app/document/UI services | `pp_app_core_document_session_tests`; `pano_cli plan-new-document --work-dir D:/Paint --name demo --resolution-index 3`; `pano_cli plan-new-document --work-dir D:/Paint --name demo --resolution-index 3 --target-exists`; `pano_cli simulate-app-session --save-intent save`; `ctest --preset desktop-fast --build-config Debug` | New document creation, overwrite confirmation, canvas/document allocation, default layer creation, history clearing, title updates, dirty/new-document state, and keyboard/dialog cleanup are owned by injected app/document/UI services with `App::dialog_newdoc` acting only as a UI adapter |
|
||||
| DEBT-0042 | Open | Modernization | Accepted Save As and Save Version planning/execution dispatch now consumes pure `pp_app_core` through `App::dialog_save`, `App::dialog_save_ver`, `pano_cli plan-document-file`, `pano_cli plan-document-version`, `DocumentFileSaveServices`, `DocumentVersionSaveServices`, and `src/legacy_document_session_services.*`, but the bridge still opens legacy overwrite prompts, calls legacy `Canvas::project_save`, mutates app document name/path/directory fields, marks version saves dirty before saving, updates the title, and handles keyboard/dialog cleanup directly | Preserve current Save As and Save Version behavior while document persistence moves toward app/document/storage/UI services | `pp_app_core_document_session_tests`; `pano_cli plan-document-file --work-dir D:/Paint --name demo --target-exists`; `pano_cli plan-document-version --directory D:/Paint --doc-name demo.01 --existing-path D:/Paint/demo.02.ppi`; `pano_cli simulate-app-session --save-intent save-as`; `pano_cli simulate-app-session --save-intent save-version`; `ctest --preset desktop-fast --build-config Debug` | Save As overwrite prompting, project-save execution, app document metadata updates, title updates, version-save dirty-state handling, and keyboard/dialog cleanup are owned by injected app/document/storage/UI services with `App::dialog_save` and `App::dialog_save_ver` acting only as UI adapters |
|
||||
| DEBT-0043 | Open | Modernization | Equirectangular, layer, animation-frame, depth, and cube-face export planning/execution dispatch now consumes pure `pp_app_core` through `App::dialog_export`, `App::dialog_export_layers`, `App::dialog_export_anim_frames`, `App::dialog_export_depth`, `App::dialog_export_cube_faces`, `pano_cli plan-export-*`, `DocumentExportServices`, and `src/legacy_document_export_services.*`, but the bridge still calls legacy `Canvas` export methods, owns platform-specific export success messages, creates export directories, handles picker-selected stems, and performs Web prepared-file handoff directly | Preserve current image/collection/depth/cube export behavior while export execution moves toward document/renderer/platform/storage services | `pp_app_core_document_export_tests`; `pano_cli plan-export-start --requires-license --demo`; `pano_cli plan-export-menu --kind layers`; `pano_cli plan-export-target --kind collection --work-dir D:/Paint --doc-name demo --suffix _layers`; `pano_cli simulate-document-export`; `ctest --preset desktop-fast --build-config Debug` | File, collection, stem, depth, and cube export execution, export-directory creation, platform success reporting, Web file handoff, and legacy canvas export calls are owned by injected document/renderer/platform/storage services with export dialogs acting only as UI adapters |
|
||||
| DEBT-0044 | Open | Modernization | Timelapse and animation MP4 export execution dispatch now consumes pure `pp_app_core` through `App::dialog_timelapse_export`, `App::dialog_export_mp4`, `pano_cli plan-export-menu`, `pano_cli plan-export-target --kind name`, `DocumentVideoExportServices`, and `src/legacy_document_export_services.*`, but the bridge still launches legacy desktop timelapse worker threads, calls `App::rec_export`, calls `Canvas::export_anim_mp4`, owns mobile/Web save callbacks, and emits success messages directly | Preserve current MP4/timelapse export behavior while video export moves toward app/document/renderer/video/platform/storage services | `pp_app_core_document_export_tests`; `pano_cli plan-export-menu --kind animation-mp4`; `pano_cli plan-export-menu --kind timelapse`; `pano_cli plan-export-target --kind name --doc-name demo --suffix -animation`; `pano_cli plan-export-target --kind name --doc-name demo --suffix -timelapse`; `ctest --preset desktop-fast --build-config Debug` | Timelapse and animation MP4 execution, desktop worker threading, frame readback/video encoding handoff, mobile/Web save callbacks, and success reporting are owned by injected app/document/renderer/video/platform/storage services with export dialogs acting only as UI adapters |
|
||||
|
||||
## Closed Debt
|
||||
|
||||
|
||||
@@ -758,6 +758,12 @@ named export work through app-core document export executors and
|
||||
directory creation, picker-selected stems, Web prepared-file handoff, and legacy
|
||||
`Canvas` export calls while retained execution remains tracked under
|
||||
`DEBT-0043`.
|
||||
`App::dialog_timelapse_export` and `App::dialog_export_mp4` now route
|
||||
picker-selected MP4 export paths through the app-core document video export
|
||||
executor and `src/legacy_document_export_services.*`, preserving mobile/Web
|
||||
suggested-name save callbacks, desktop worker-thread timelapse export,
|
||||
`App::rec_export`, animation `Canvas::export_anim_mp4` dispatch, and existing
|
||||
success messages while retained execution remains tracked under `DEBT-0044`.
|
||||
|
||||
Implementation tasks:
|
||||
|
||||
@@ -1330,6 +1336,15 @@ Results:
|
||||
- Focused export CTest coverage passed for `pp_app_core_document_export_tests`,
|
||||
`pano_cli_plan_export_start/menu/target_*`, and
|
||||
`pano_cli_simulate_document_export_smoke` after the live bridge split.
|
||||
- `PanoPainter`, `pp_app_core_document_export_tests`, and `pano_cli` built
|
||||
after timelapse and animation MP4 export execution moved behind document
|
||||
video export services. A clean rebuild was required once because MSVC
|
||||
reported the known Debug PDB `LNK1103` corruption, after which the app,
|
||||
export tests, and `pano_cli` targets built cleanly.
|
||||
- Focused video export CTest coverage passed for
|
||||
`pp_app_core_document_export_tests`, `pano_cli_plan_export_menu_*`,
|
||||
`pano_cli_plan_export_target_name_smoke`, and
|
||||
`pano_cli_simulate_document_export_smoke`.
|
||||
- `pp_app_core_document_recording_tests` passed, covering recording start/stop,
|
||||
clear, platform recorded-file cleanup, frame-count reset, export progress
|
||||
totals, and oversized progress-total clamping.
|
||||
|
||||
Reference in New Issue
Block a user