Move cloud transfer helpers to legacy cloud services

This commit is contained in:
2026-06-15 20:05:46 +02:00
parent 1a5868376b
commit ccde4d69f4
6 changed files with 183 additions and 130 deletions

File diff suppressed because one or more lines are too long

View File

@@ -82,6 +82,12 @@ The cloud browser dialog now also opens through that seam from
now concentrated in retained background worker threads, transfer helpers,
project-open refresh, and dialog-internal legacy behavior instead of raw root
insertion.
Retained upload/download CURL setup, TLS-bypass policy consumption, and
progress callback dispatch now also live in `src/legacy_cloud_services.*`
instead of `App::upload` and `App::download`, leaving the remaining cloud debt
focused on save-before-upload execution, upload form/response handling,
prompt/progress lifetime, OpenGL context guarding, downloaded-project open,
layer refresh, and action-history reset.
Recent 2026-06-13 retained preview reductions continue to narrow DEBT-0036:
`NodeStrokePreview::draw_stroke_immediate()` now also routes

View File

@@ -38,7 +38,7 @@ auditable steps rather than by subjective estimates.
| Renderer boundary and OpenGL parity | 15 | 11 | Live render/export/readback paths execute through renderer interfaces with parity checks. |
| Platform and package parity | 10 | 8 | Required platforms have root CMake/package validation and injected platform services. |
| Hardening and future backend readiness | 10 | 4 | Edge, fuzz, golden, stress, and backend-lab gates exist for high-risk paths. |
| **Total** | **100** | **66** | Only completed tasks below may change this number. |
| **Total** | **100** | **67** | Only completed tasks below may change this number. |
When updating `Current`, add a dated note under "Completed Task Log" with the
task id, points moved, validation command, and commit hash.
@@ -370,6 +370,46 @@ Completed Task Log:
| --- | --- | ---: | --- | --- |
| 2026-06-15 | ADP-008 | +1 legacy adapter retirement | `ctest --preset desktop-fast --build-config Debug -R "pp_ui_core_node_lifetime\|pp_ui_core_overlay_lifetime" --output-on-failure`; `MSBuild.exe out\build\windows-msvc-default\tests\pp_app_core_document_cloud_tests.vcxproj /p:Configuration=Debug /p:Platform=x64`; `D:\Dev\panopainter\out\build\windows-msvc-default\tests\Debug\pp_app_core_document_cloud_tests.exe`; `MSBuild.exe out\build\windows-msvc-default\panopainter_app.vcxproj /p:Configuration=Debug /p:Platform=x64` | `5bf0a4f6` |
### ADP-009 - Move Cloud Transfer Helpers To Legacy Cloud Services
Status: Done
Score: +1 legacy adapter retirement
Debt: `DEBT-0038`
Scope: `src/legacy_cloud_services.*`, `src/app.cpp`, `src/app.h`,
cloud transfer helper path only
Goal:
Move the retained upload/download CURL execution off `App` ownership and into
`src/legacy_cloud_services.*` so the cloud bridge owns the live transfer helper
path directly without changing prompt flow, TLS policy, progress callbacks, or
downloaded-project refresh behavior.
Done Checks:
- Live cloud upload/download behavior stays unchanged for the retained adapter
path.
- `App::upload` and `App::download` no longer own the retained CURL setup and
progress callback execution.
- `src/legacy_cloud_services.*` owns the retained upload/download transfer
helpers directly, and `DEBT-0038` describes the reduced remaining cloud
bridge surface.
Validation:
```powershell
ctest --preset desktop-fast --build-config Debug -R "pp_app_core_document_cloud" --output-on-failure
& 'C:\Program Files\Microsoft Visual Studio\18\Community\MSBuild\Current\Bin\MSBuild.exe' out\build\windows-msvc-default\tests\pp_app_core_document_cloud_tests.vcxproj /p:Configuration=Debug /p:Platform=x64
& 'C:\Program Files\Microsoft Visual Studio\18\Community\MSBuild\Current\Bin\MSBuild.exe' out\build\windows-msvc-default\panopainter_app.vcxproj /p:Configuration=Debug /p:Platform=x64
.\out\build\windows-msvc-default\tests\Debug\pp_app_core_document_cloud_tests.exe
```
Completed Task Log:
| Date | Task | Score | Validation | Commit |
| --- | --- | ---: | --- | --- |
| 2026-06-15 | ADP-009 | +1 legacy adapter retirement | `ctest --preset desktop-fast --build-config Debug -R "pp_app_core_document_cloud" --output-on-failure`; `MSBuild.exe out\build\windows-msvc-default\tests\pp_app_core_document_cloud_tests.vcxproj /p:Configuration=Debug /p:Platform=x64`; `MSBuild.exe out\build\windows-msvc-default\panopainter_app.vcxproj /p:Configuration=Debug /p:Platform=x64`; `.\out\build\windows-msvc-default\tests\Debug\pp_app_core_document_cloud_tests.exe` | `(pending)` |
Completed Task Log:
| Date | Task | Score | Validation | Commit |