From de2aedb96b99a38541207992ad130929ccc3973e Mon Sep 17 00:00:00 2001 From: omigamedev Date: Mon, 15 Jun 2026 22:42:26 +0200 Subject: [PATCH] Record open project result branch closeout --- docs/modernization/debt.md | 6 ++++++ docs/modernization/roadmap.md | 4 ++++ docs/modernization/tasks.md | 39 +++++++++++++++++++++++++++++++++++ 3 files changed, 49 insertions(+) diff --git a/docs/modernization/debt.md b/docs/modernization/debt.md index 81f0bbb1..2564c065 100644 --- a/docs/modernization/debt.md +++ b/docs/modernization/debt.md @@ -76,6 +76,12 @@ agent or engineer to remove them without reconstructing context from chat. inline in the retained document-open helper; the remaining document-open bridge debt stays concentrated in layer refresh, title updates, and retained history services. +- 2026-06-15: `DEBT-0039` was narrowed again. The retained project-open + layer/title update work and failure-path error dialog in + `handle_open_legacy_project_result()` now route through focused helpers in + `src/legacy_document_open_services.cpp` instead of living inline in the + retained document-open helper; the remaining document-open bridge debt stays + concentrated in retained history services. - 2026-06-15: `DEBT-0038` was narrowed again. The retained cloud downloaded- project open camera reset and layer-clear setup in `execute_legacy_downloaded_project_open()` now routes through a focused diff --git a/docs/modernization/roadmap.md b/docs/modernization/roadmap.md index 87315735..3c5735e4 100644 --- a/docs/modernization/roadmap.md +++ b/docs/modernization/roadmap.md @@ -1404,6 +1404,10 @@ The retained project-open success/failure handling in `open_legacy_project()` now also routes through a focused helper, so the remaining document-open bridge debt is further concentrated on layer refresh, title updates, and retained history services. +The retained project-open layer/title update work and failure-path error +dialog in `handle_open_legacy_project_result()` now also route through focused +helpers, so the remaining document-open bridge debt is further concentrated on +retained history services. `App::request_close`, `App::save_document`, and `App::continue_document_workflow_after_optional_save` now route through app-core document-session executors and `src/legacy_document_session_services.*`, diff --git a/docs/modernization/tasks.md b/docs/modernization/tasks.md index 1438e574..dcc6894b 100644 --- a/docs/modernization/tasks.md +++ b/docs/modernization/tasks.md @@ -1739,6 +1739,45 @@ Completed Task Log: | --- | --- | ---: | --- | --- | | 2026-06-15 | ADP-046 | no score movement | `powershell -ExecutionPolicy Bypass -File scripts\\automation\\quiet-validate.ps1 -BuildTargets pano_cli -TestRegex "pp_app_core_document_route|pp_app_core_document_session"` | `7b8da2f0` | +### ADP-047 - Extract Document-Open Project Result Branch Helpers + +Status: Done +Score: no score movement +Debt: `DEBT-0039` +Scope: `src/legacy_document_open_services.cpp` only + +Closeout: `2f2b9621` + +Goal: + +Reduce the inline retained project-open result branch surface by extracting the +success-path layer refresh and failure-path error dialog from +`handle_open_legacy_project_result()` into focused helpers while preserving +current behavior. + +Done Checks: + +- The retained project-open success-path layer/title work no longer lives + inline in `handle_open_legacy_project_result()`. +- The retained project-open failure-path error dialog no longer lives inline in + `handle_open_legacy_project_result()`. +- The retained project-open result path now routes through focused helpers in + `src/legacy_document_open_services.cpp`. +- `DEBT-0039` and the roadmap note the reduced remaining document-open bridge + surface. + +Validation: + +```powershell +powershell -ExecutionPolicy Bypass -File scripts\\automation\\quiet-validate.ps1 -BuildTargets pano_cli -TestRegex "pp_app_core_document_route|pp_app_core_document_session" +``` + +Completed Task Log: + +| Date | Task | Score | Validation | Commit | +| --- | --- | ---: | --- | --- | +| 2026-06-15 | ADP-047 | no score movement | `powershell -ExecutionPolicy Bypass -File scripts\\automation\\quiet-validate.ps1 -BuildTargets pano_cli -TestRegex "pp_app_core_document_route|pp_app_core_document_session"` | `2f2b9621` | + ### RND-001 - Make Pure Equirectangular Export The Primary Success Path Status: Done