Move stroke commit request assembly behind service helper

src/canvas.cpp

@@ -736,19 +736,6 @@ static auto make_canvas_stroke_commit_callbacks(
         });
 }
 
-static auto make_canvas_stroke_commit_request(
-    const std::array<pp::panopainter::LegacyCanvasStrokeCommitFace, 6>& faces,
-    const pp::paint_renderer::CanvasStrokeCommitSequencePlan& sequence,
-    const pp::panopainter::LegacyCanvasStrokeCommitCallbacks& callbacks)
-{
-    return pp::panopainter::LegacyCanvasStrokeCommitRequest {
-        .context = "Canvas::stroke_commit",
-        .faces = faces,
-        .sequence = sequence,
-        .callbacks = callbacks,
-    };
-}
-
 glm::vec4 Canvas::stroke_draw_samples(
     int i,
     std::vector<vertex_t>& P,
@@ -1353,7 +1340,7 @@ void Canvas::stroke_commit()
     };
 
     [[maybe_unused]] const auto commit_result = pp::panopainter::execute_legacy_canvas_stroke_commit_sequence(
-        make_canvas_stroke_commit_request(faces, sequence, commit_callbacks));
+        pp::panopainter::make_legacy_canvas_stroke_commit_request(faces, sequence, commit_callbacks));
 }
 
 void Canvas::stroke_commit_timelapse()

src/legacy_canvas_stroke_commit_services.h

@@ -165,6 +165,19 @@ inline void bind_legacy_canvas_stroke_commit_face_inputs(
         std::forward<BindFaceSamplerRole>(bind_face_sampler_role));
 }
 
+[[nodiscard]] inline LegacyCanvasStrokeCommitRequest make_legacy_canvas_stroke_commit_request(
+    const std::array<LegacyCanvasStrokeCommitFace, 6>& faces,
+    const pp::paint_renderer::CanvasStrokeCommitSequencePlan& sequence,
+    const LegacyCanvasStrokeCommitCallbacks& callbacks)
+{
+    return LegacyCanvasStrokeCommitRequest {
+        .context = "Canvas::stroke_commit",
+        .faces = faces,
+        .sequence = sequence,
+        .callbacks = callbacks,
+    };
+}
+
 template <typename SetupShader, typename DrawPlane>
 inline void execute_legacy_canvas_stroke_commit_erase(
     SetupShader&& setup_shader,