From eacf862c0bc96f938ab5117b223a694aa91b57ce Mon Sep 17 00:00:00 2001 From: omigamedev Date: Mon, 15 Jun 2026 22:51:57 +0200 Subject: [PATCH] Record shared history bridge closeout --- docs/modernization/debt.md | 5 +++++ docs/modernization/roadmap.md | 4 ++++ docs/modernization/tasks.md | 36 +++++++++++++++++++++++++++++++++++ 3 files changed, 45 insertions(+) diff --git a/docs/modernization/debt.md b/docs/modernization/debt.md index 96113364..edf0035a 100644 --- a/docs/modernization/debt.md +++ b/docs/modernization/debt.md @@ -87,6 +87,11 @@ agent or engineer to remove them without reconstructing context from chat. helper in `src/legacy_document_open_services.cpp` instead of living inline in the retained document-open helper; the remaining document-open bridge debt stays concentrated in retained history services. +- 2026-06-15: `DEBT-0039`/`DEBT-0040` were narrowed again. The retained + history adapter now reuses the shared `src/legacy_history_services.*` helper + from both document-open and document-session bridges instead of living + inline in those bridge files; the remaining bridge debt stays concentrated in + retained history services. - 2026-06-15: `DEBT-0038` was narrowed again. The retained cloud downloaded- project open camera reset and layer-clear setup in `execute_legacy_downloaded_project_open()` now routes through a focused diff --git a/docs/modernization/roadmap.md b/docs/modernization/roadmap.md index 086dcc1d..ba949ff7 100644 --- a/docs/modernization/roadmap.md +++ b/docs/modernization/roadmap.md @@ -1411,6 +1411,10 @@ retained history services. The retained project-open history-planning call in `open_legacy_project()` now also routes through a focused helper, so the remaining document-open bridge debt is further concentrated on retained history services. +The retained history adapter now also reuses the shared +`src/legacy_history_services.*` helper from both document-open and +document-session bridges, so the remaining bridge debt is further concentrated +on retained history services. `App::request_close`, `App::save_document`, and `App::continue_document_workflow_after_optional_save` now route through app-core document-session executors and `src/legacy_document_session_services.*`, diff --git a/docs/modernization/tasks.md b/docs/modernization/tasks.md index 1b56af3d..b6c6eb1f 100644 --- a/docs/modernization/tasks.md +++ b/docs/modernization/tasks.md @@ -1815,6 +1815,42 @@ Completed Task Log: | --- | --- | ---: | --- | --- | | 2026-06-15 | ADP-048 | no score movement | `powershell -ExecutionPolicy Bypass -File scripts\\automation\\quiet-validate.ps1 -BuildTargets pano_cli -TestRegex "pp_app_core_document_route|pp_app_core_document_session"` | `c2083565` | +### ADP-049 - Reuse Shared History Service In Document Bridges + +Status: Done +Score: no score movement +Debt: `DEBT-0039`, `DEBT-0040` +Scope: `src/legacy_document_open_services.cpp`, `src/legacy_document_session_services.cpp` + +Closeout: `530e572e` + +Goal: + +Reduce the duplicated retained history adapter surface by reusing the shared +`src/legacy_history_services.*` helper from both document-open and +document-session bridges while preserving current behavior. + +Done Checks: + +- The retained history adapter no longer lives inline in the document-open and + document-session bridges. +- The retained document-open and document-session history paths now reuse the + shared `src/legacy_history_services.*` helper. +- `DEBT-0039`, `DEBT-0040`, and the roadmap note the reduced retained history + adapter surface. + +Validation: + +```powershell +powershell -ExecutionPolicy Bypass -File scripts\\automation\\quiet-validate.ps1 -BuildTargets pano_cli -TestRegex "pp_app_core_document_route|pp_app_core_document_session" +``` + +Completed Task Log: + +| Date | Task | Score | Validation | Commit | +| --- | --- | ---: | --- | --- | +| 2026-06-15 | ADP-049 | no score movement | `powershell -ExecutionPolicy Bypass -File scripts\\automation\\quiet-validate.ps1 -BuildTargets pano_cli -TestRegex "pp_app_core_document_route|pp_app_core_document_session"` | `530e572e` | + ### RND-001 - Make Pure Equirectangular Export The Primary Success Path Status: Done