Add renderer and package readiness validation gates

scripts/automation/package-smoke.ps1

@@ -99,6 +99,89 @@ function New-PackageReadiness {
     }
 }
 
+function Resolve-PackageStatus {
+    param(
+        [bool]$RootCMakePackageTargetAvailable,
+        [bool]$GateBlocked,
+        [object[]]$Prerequisites
+    )
+
+    if ($GateBlocked) {
+        return "blocked"
+    }
+
+    foreach ($prerequisite in $Prerequisites) {
+        if ($prerequisite.name -eq "root-cmake-package-target") {
+            continue
+        }
+        if (-not $prerequisite.available) {
+            return "blocked"
+        }
+    }
+
+    if ($RootCMakePackageTargetAvailable) {
+        return "validated"
+    }
+
+    return "compile-only"
+}
+
+function Get-AndroidNativeCheckInfo {
+    param(
+        [string]$Kind,
+        [bool]$AndroidNativeChecks,
+        [object]$AndroidNativeValidation
+    )
+
+    $command = switch ($Kind) {
+        "android-standard-apk" { "powershell -ExecutionPolicy Bypass -File scripts/automation/android-legacy-package-build.ps1 -Packages standard" }
+        "android-quest-apk" { "powershell -ExecutionPolicy Bypass -File scripts/automation/android-legacy-package-build.ps1 -Packages quest -ConfigureOnly" }
+        "android-focus-apk" { "powershell -ExecutionPolicy Bypass -File scripts/automation/android-legacy-package-build.ps1 -Packages focus -ConfigureOnly" }
+        default { "" }
+    }
+
+    if (-not $AndroidNativeChecks) {
+        return @{ Available = $true; Detail = "$command (not run)" }
+    }
+
+    if ($command.Length -eq 0) {
+        return @{ Available = $false; Detail = "No Android native check plan for kind '$Kind'" }
+    }
+
+    $packages = switch ($Kind) {
+        "android-standard-apk" { @("standard") }
+        "android-quest-apk" { @("quest") }
+        "android-focus-apk" { @("focus") }
+        default { @() }
+    }
+
+    $result = $null
+    foreach ($entry in $AndroidNativeValidation.results) {
+        $hasAll = $true
+        foreach ($pkg in $packages) {
+            if (-not ($entry.packages -contains $pkg)) {
+                $hasAll = $false
+                break
+            }
+        }
+
+        if ($hasAll) {
+            $result = $entry
+            break
+        }
+    }
+
+    if (-not $result) {
+        return @{ Available = $false; Detail = "$command (not executed)" }
+    }
+
+    if ($result.exitCode -ne 0) {
+        return @{ Available = $false; Detail = "$command (exit $($result.exitCode))" }
+    }
+
+    return @{ Available = $true; Detail = $command }
+}
+
 function Get-AndroidNativeCheckPlan {
     param([string[]]$Kinds)
 
@@ -188,18 +271,20 @@ function Get-PackageReadiness {
                 $wapproj = Join-Path $root "PanoPainterPackage/PanoPainterPackage.wapproj"
                 $manifest = Join-Path $root "PanoPainterPackage/Package.appxmanifest"
                 $appPackages = Join-Path $root "PanoPainterPackage/AppPackages"
+                $prerequisites = @(
+                    (New-Prerequisite -Name "legacy-wapproj" -Available (Test-Path -LiteralPath $wapproj -PathType Leaf) -Detail $wapproj),
+                    (New-Prerequisite -Name "appx-manifest" -Available (Test-Path -LiteralPath $manifest -PathType Leaf) -Detail $manifest),
+                    (New-Prerequisite -Name "makeappx" -Available (Test-CommandAvailable "makeappx") -Detail "Windows SDK packaging tool"),
+                    (New-Prerequisite -Name "signtool" -Available (Test-CommandAvailable "signtool") -Detail "Windows SDK signing tool"),
+                    (New-Prerequisite -Name "root-cmake-package-target" -Available $false -Detail "Not migrated yet")
+                )
+                $status = Resolve-PackageStatus -RootCMakePackageTargetAvailable $false -GateBlocked $true -Prerequisites $prerequisites
                 $readiness += New-PackageReadiness `
                     -Kind $kind `
-                    -Status "blocked" `
+                    -Status $status `
                     -Reason "legacy-wapproj-present-but-root-cmake-package-target-missing" `
                     -ValidationCommand "msbuild PanoPainterPackage/PanoPainterPackage.wapproj /p:Configuration=$Configuration /p:Platform=x64" `
-                    -Prerequisites @(
-                        (New-Prerequisite -Name "legacy-wapproj" -Available (Test-Path -LiteralPath $wapproj -PathType Leaf) -Detail $wapproj),
-                        (New-Prerequisite -Name "appx-manifest" -Available (Test-Path -LiteralPath $manifest -PathType Leaf) -Detail $manifest),
-                        (New-Prerequisite -Name "makeappx" -Available (Test-CommandAvailable "makeappx") -Detail "Windows SDK packaging tool"),
-                        (New-Prerequisite -Name "signtool" -Available (Test-CommandAvailable "signtool") -Detail "Windows SDK signing tool"),
-                        (New-Prerequisite -Name "root-cmake-package-target" -Available $false -Detail "Not migrated yet")
-                    ) `
+                    -Prerequisites $prerequisites `
                     -Artifacts @(
                         (New-ArtifactCheck -Name "app-packages" -Path $appPackages -PathType "Container")
                     )
@@ -208,19 +293,22 @@ function Get-PackageReadiness {
                 $gradle = Join-Path $root "android/android/build.gradle"
                 $manifest = Join-Path $root "android/android/src/main/AndroidManifest.xml"
                 $apkDir = Join-Path $root "android/android/build/outputs/apk"
+                $androidNativeCheck = Get-AndroidNativeCheckInfo -Kind $kind -AndroidNativeChecks $AndroidNativeChecks -AndroidNativeValidation $androidNativeValidation
+                $prerequisites = @(
+                    (New-Prerequisite -Name "gradle-build" -Available (Test-Path -LiteralPath $gradle -PathType Leaf) -Detail $gradle),
+                    (New-Prerequisite -Name "android-manifest" -Available (Test-Path -LiteralPath $manifest -PathType Leaf) -Detail $manifest),
+                    (New-Prerequisite -Name "gradle" -Available (Test-CommandAvailable "gradle") -Detail "Android package builder"),
+                    (New-Prerequisite -Name "retained-native-cmake-check" -Available $androidNativeCheck.Available -Detail $androidNativeCheck.Detail),
+                    (New-Prerequisite -Name "root-cmake-preset" -Available $true -Detail "android-arm64/android-x64"),
+                    (New-Prerequisite -Name "root-cmake-package-target" -Available $false -Detail "Not migrated yet")
+                )
+                $status = Resolve-PackageStatus -RootCMakePackageTargetAvailable $false -GateBlocked $false -Prerequisites $prerequisites
                 $readiness += New-PackageReadiness `
                     -Kind $kind `
-                    -Status "blocked" `
+                    -Status $status `
                     -Reason "legacy-gradle-package-not-consuming-root-cmake-targets" `
                     -ValidationCommand "gradle -p android/android assembleDebug" `
-                    -Prerequisites @(
-                        (New-Prerequisite -Name "gradle-build" -Available (Test-Path -LiteralPath $gradle -PathType Leaf) -Detail $gradle),
-                        (New-Prerequisite -Name "android-manifest" -Available (Test-Path -LiteralPath $manifest -PathType Leaf) -Detail $manifest),
-                        (New-Prerequisite -Name "gradle" -Available (Test-CommandAvailable "gradle") -Detail "Android package builder"),
-                        (New-Prerequisite -Name "retained-native-cmake-check" -Available $true -Detail "powershell -ExecutionPolicy Bypass -File scripts\automation\android-legacy-package-build.ps1 -Packages standard"),
-                        (New-Prerequisite -Name "root-cmake-preset" -Available $true -Detail "android-arm64/android-x64"),
-                        (New-Prerequisite -Name "root-cmake-package-target" -Available $false -Detail "Not migrated yet")
-                    ) `
+                    -Prerequisites $prerequisites `
                     -Artifacts @(
                         (New-ArtifactCheck -Name "apk-output" -Path $apkDir -PathType "Container")
                     )
@@ -229,19 +317,22 @@ function Get-PackageReadiness {
                 $gradle = Join-Path $root "android/quest/build.gradle"
                 $manifest = Join-Path $root "android/quest/src/main/AndroidManifest.xml"
                 $apkDir = Join-Path $root "android/quest/build/outputs/apk"
+                $androidNativeCheck = Get-AndroidNativeCheckInfo -Kind $kind -AndroidNativeChecks $AndroidNativeChecks -AndroidNativeValidation $androidNativeValidation
+                $prerequisites = @(
+                    (New-Prerequisite -Name "gradle-build" -Available (Test-Path -LiteralPath $gradle -PathType Leaf) -Detail $gradle),
+                    (New-Prerequisite -Name "android-manifest" -Available (Test-Path -LiteralPath $manifest -PathType Leaf) -Detail $manifest),
+                    (New-Prerequisite -Name "gradle" -Available (Test-CommandAvailable "gradle") -Detail "Android package builder"),
+                    (New-Prerequisite -Name "retained-native-cmake-check" -Available $androidNativeCheck.Available -Detail $androidNativeCheck.Detail),
+                    (New-Prerequisite -Name "root-cmake-preset" -Available $true -Detail "android-quest-arm64"),
+                    (New-Prerequisite -Name "root-cmake-package-target" -Available $false -Detail "Not migrated yet")
+                )
+                $status = Resolve-PackageStatus -RootCMakePackageTargetAvailable $false -GateBlocked $false -Prerequisites $prerequisites
                 $readiness += New-PackageReadiness `
                     -Kind $kind `
-                    -Status "blocked" `
+                    -Status $status `
                     -Reason "legacy-gradle-package-not-consuming-root-cmake-targets" `
                     -ValidationCommand "gradle -p android/quest assembleDebug" `
-                    -Prerequisites @(
-                        (New-Prerequisite -Name "gradle-build" -Available (Test-Path -LiteralPath $gradle -PathType Leaf) -Detail $gradle),
-                        (New-Prerequisite -Name "android-manifest" -Available (Test-Path -LiteralPath $manifest -PathType Leaf) -Detail $manifest),
-                        (New-Prerequisite -Name "gradle" -Available (Test-CommandAvailable "gradle") -Detail "Android package builder"),
-                        (New-Prerequisite -Name "retained-native-cmake-check" -Available $true -Detail "powershell -ExecutionPolicy Bypass -File scripts\automation\android-legacy-package-build.ps1 -Packages quest -ConfigureOnly"),
-                        (New-Prerequisite -Name "root-cmake-preset" -Available $true -Detail "android-quest-arm64"),
-                        (New-Prerequisite -Name "root-cmake-package-target" -Available $false -Detail "Not migrated yet")
-                    ) `
+                    -Prerequisites $prerequisites `
                     -Artifacts @(
                         (New-ArtifactCheck -Name "apk-output" -Path $apkDir -PathType "Container")
                     )
@@ -250,19 +341,22 @@ function Get-PackageReadiness {
                 $gradle = Join-Path $root "android/focus/build.gradle"
                 $manifest = Join-Path $root "android/focus/src/main/AndroidManifest.xml"
                 $apkDir = Join-Path $root "android/focus/build/outputs/apk"
+                $androidNativeCheck = Get-AndroidNativeCheckInfo -Kind $kind -AndroidNativeChecks $AndroidNativeChecks -AndroidNativeValidation $androidNativeValidation
+                $prerequisites = @(
+                    (New-Prerequisite -Name "gradle-build" -Available (Test-Path -LiteralPath $gradle -PathType Leaf) -Detail $gradle),
+                    (New-Prerequisite -Name "android-manifest" -Available (Test-Path -LiteralPath $manifest -PathType Leaf) -Detail $manifest),
+                    (New-Prerequisite -Name "gradle" -Available (Test-CommandAvailable "gradle") -Detail "Android package builder"),
+                    (New-Prerequisite -Name "retained-native-cmake-check" -Available $androidNativeCheck.Available -Detail $androidNativeCheck.Detail),
+                    (New-Prerequisite -Name "root-cmake-preset" -Available $true -Detail "android-focus-arm64"),
+                    (New-Prerequisite -Name "root-cmake-package-target" -Available $false -Detail "Not migrated yet")
+                )
+                $status = Resolve-PackageStatus -RootCMakePackageTargetAvailable $false -GateBlocked $false -Prerequisites $prerequisites
                 $readiness += New-PackageReadiness `
                     -Kind $kind `
-                    -Status "blocked" `
+                    -Status $status `
                     -Reason "legacy-gradle-package-not-consuming-root-cmake-targets" `
                     -ValidationCommand "gradle -p android/focus assembleDebug" `
-                    -Prerequisites @(
-                        (New-Prerequisite -Name "gradle-build" -Available (Test-Path -LiteralPath $gradle -PathType Leaf) -Detail $gradle),
-                        (New-Prerequisite -Name "android-manifest" -Available (Test-Path -LiteralPath $manifest -PathType Leaf) -Detail $manifest),
-                        (New-Prerequisite -Name "gradle" -Available (Test-CommandAvailable "gradle") -Detail "Android package builder"),
-                        (New-Prerequisite -Name "retained-native-cmake-check" -Available $true -Detail "powershell -ExecutionPolicy Bypass -File scripts\automation\android-legacy-package-build.ps1 -Packages focus -ConfigureOnly"),
-                        (New-Prerequisite -Name "root-cmake-preset" -Available $true -Detail "android-focus-arm64"),
-                        (New-Prerequisite -Name "root-cmake-package-target" -Available $false -Detail "Not migrated yet")
-                    ) `
+                    -Prerequisites $prerequisites `
                     -Artifacts @(
                         (New-ArtifactCheck -Name "apk-output" -Path $apkDir -PathType "Container")
                     )
@@ -270,17 +364,19 @@ function Get-PackageReadiness {
             "apple-bundle" {
                 $xcodeProject = Join-Path $root "PanoPainter.xcodeproj/project.pbxproj"
                 $bundleDir = Join-Path $root "out/package/apple"
+                $prerequisites = @(
+                    (New-Prerequisite -Name "legacy-xcode-project" -Available (Test-Path -LiteralPath $xcodeProject -PathType Leaf) -Detail $xcodeProject),
+                    (New-Prerequisite -Name "xcodebuild" -Available (Test-CommandAvailable "xcodebuild") -Detail "Apple package builder"),
+                    (New-Prerequisite -Name "root-cmake-preset" -Available $true -Detail "macos/ios-device/ios-simulator"),
+                    (New-Prerequisite -Name "root-cmake-package-target" -Available $false -Detail "Not migrated yet")
+                )
+                $status = Resolve-PackageStatus -RootCMakePackageTargetAvailable $false -GateBlocked $true -Prerequisites $prerequisites
                 $readiness += New-PackageReadiness `
                     -Kind $kind `
-                    -Status "blocked" `
+                    -Status $status `
                     -Reason "legacy-xcode-project-and-host-toolchain-not-aligned-with-root-cmake-package-target" `
                     -ValidationCommand "xcodebuild -project PanoPainter.xcodeproj -configuration $Configuration" `
-                    -Prerequisites @(
-                        (New-Prerequisite -Name "legacy-xcode-project" -Available (Test-Path -LiteralPath $xcodeProject -PathType Leaf) -Detail $xcodeProject),
-                        (New-Prerequisite -Name "xcodebuild" -Available (Test-CommandAvailable "xcodebuild") -Detail "Apple package builder"),
-                        (New-Prerequisite -Name "root-cmake-preset" -Available $true -Detail "macos/ios-device/ios-simulator"),
-                        (New-Prerequisite -Name "root-cmake-package-target" -Available $false -Detail "Not migrated yet")
-                    ) `
+                    -Prerequisites $prerequisites `
                     -Artifacts @(
                         (New-ArtifactCheck -Name "apple-package-output" -Path $bundleDir -PathType "Container")
                     )
@@ -288,18 +384,20 @@ function Get-PackageReadiness {
             "linux-app" {
                 $linuxCmake = Join-Path $root "linux/CMakeLists.txt"
                 $linuxBinary = Join-Path $root "out/package/linux/panopainter"
+                $prerequisites = @(
+                    (New-Prerequisite -Name "retained-linux-cmake" -Available (Test-Path -LiteralPath $linuxCmake -PathType Leaf) -Detail $linuxCmake),
+                    (New-Prerequisite -Name "cmake" -Available (Test-CommandAvailable "cmake") -Detail "Linux retained app CMake configure/build tool"),
+                    (New-Prerequisite -Name "retained-platform-cmake-baseline" -Available $true -Detail "python scripts/dev/check_retained_platform_cmake.py"),
+                    (New-Prerequisite -Name "root-cmake-preset" -Available $true -Detail "linux-clang"),
+                    (New-Prerequisite -Name "root-cmake-package-target" -Available $false -Detail "Not migrated yet")
+                )
+                $status = Resolve-PackageStatus -RootCMakePackageTargetAvailable $false -GateBlocked $false -Prerequisites $prerequisites
                 $readiness += New-PackageReadiness `
                     -Kind $kind `
-                    -Status "blocked" `
+                    -Status $status `
                     -Reason "retained-linux-cmake-not-consuming-root-cmake-targets" `
                     -ValidationCommand "cmake -S linux -B out/package/linux-retained && cmake --build out/package/linux-retained --target panopainter" `
-                    -Prerequisites @(
-                        (New-Prerequisite -Name "retained-linux-cmake" -Available (Test-Path -LiteralPath $linuxCmake -PathType Leaf) -Detail $linuxCmake),
-                        (New-Prerequisite -Name "cmake" -Available (Test-CommandAvailable "cmake") -Detail "Linux retained app CMake configure/build tool"),
-                        (New-Prerequisite -Name "retained-platform-cmake-baseline" -Available $true -Detail "python scripts/dev/check_retained_platform_cmake.py"),
-                        (New-Prerequisite -Name "root-cmake-preset" -Available $true -Detail "linux-clang"),
-                        (New-Prerequisite -Name "root-cmake-package-target" -Available $false -Detail "Not migrated yet")
-                    ) `
+                    -Prerequisites $prerequisites `
                     -Artifacts @(
                         (New-ArtifactCheck -Name "linux-app-output" -Path $linuxBinary -PathType "Leaf")
                     )
@@ -307,19 +405,21 @@ function Get-PackageReadiness {
             "webgl" {
                 $webglCmake = Join-Path $root "webgl/CMakeLists.txt"
                 $webDir = Join-Path $root "out/package/webgl"
+                $prerequisites = @(
+                    (New-Prerequisite -Name "retained-webgl-cmake" -Available (Test-Path -LiteralPath $webglCmake -PathType Leaf) -Detail $webglCmake),
+                    (New-Prerequisite -Name "emcc" -Available (Test-CommandAvailable "emcc") -Detail "Emscripten compiler"),
+                    (New-Prerequisite -Name "emcmake" -Available (Test-CommandAvailable "emcmake") -Detail "Emscripten CMake wrapper"),
+                    (New-Prerequisite -Name "retained-platform-cmake-baseline" -Available $true -Detail "python scripts/dev/check_retained_platform_cmake.py"),
+                    (New-Prerequisite -Name "root-cmake-preset" -Available $true -Detail "emscripten"),
+                    (New-Prerequisite -Name "root-cmake-package-target" -Available $false -Detail "Not migrated yet")
+                )
+                $status = Resolve-PackageStatus -RootCMakePackageTargetAvailable $false -GateBlocked $false -Prerequisites $prerequisites
                 $readiness += New-PackageReadiness `
                     -Kind $kind `
-                    -Status "blocked" `
+                    -Status $status `
                     -Reason "retained-webgl-cmake-not-consuming-root-cmake-targets" `
                     -ValidationCommand "emcmake cmake -S webgl -B out/package/webgl-retained && cmake --build out/package/webgl-retained --target panopainter" `
-                    -Prerequisites @(
-                        (New-Prerequisite -Name "retained-webgl-cmake" -Available (Test-Path -LiteralPath $webglCmake -PathType Leaf) -Detail $webglCmake),
-                        (New-Prerequisite -Name "emcc" -Available (Test-CommandAvailable "emcc") -Detail "Emscripten compiler"),
-                        (New-Prerequisite -Name "emcmake" -Available (Test-CommandAvailable "emcmake") -Detail "Emscripten CMake wrapper"),
-                        (New-Prerequisite -Name "retained-platform-cmake-baseline" -Available $true -Detail "python scripts/dev/check_retained_platform_cmake.py"),
-                        (New-Prerequisite -Name "root-cmake-preset" -Available $true -Detail "emscripten"),
-                        (New-Prerequisite -Name "root-cmake-package-target" -Available $false -Detail "Not migrated yet")
-                    ) `
+                    -Prerequisites $prerequisites `
                     -Artifacts @(
                         (New-ArtifactCheck -Name "webgl-output" -Path $webDir -PathType "Container")
                     )