Centralize legacy app preferences

docs/modernization/build-inventory.md

@@ -167,6 +167,12 @@ Known local toolchain state:
   Tools, About, history, canvas-clear, and settings execution remain tracked by
   `DEBT-0029`, `DEBT-0030`, `DEBT-0031`, `DEBT-0033`, `DEBT-0034`, and
   `DEBT-0035`.
+- `src/legacy_app_preference_services.*` is the current app-shell bridge for
+  options-menu preference execution. It keeps UI scale, viewport scale, RTL,
+  VR-controller, auto-timelapse, and canvas cursor-mode callbacks on the
+  `pp_app_core` `AppPreferenceServices` contract while retained settings
+  persistence, recording lifecycle, and legacy canvas/UI execution remain
+  tracked by `DEBT-0045`.
 - `src/legacy_canvas_tool_services.*` is the current app-shell bridge for
   canvas toolbar tool selection, NodeCanvas stylus/input mode switching, and
   canvas hotkey/touch execution. It keeps those live paths on the `pp_app_core`
@@ -576,6 +582,10 @@ Known local toolchain state:
   show/hide planning before platform keyboard callbacks, plus cursor visibility
   planning before platform cursor callbacks, plus clipboard read/write
   planning before platform clipboard callbacks.
+- `pp_app_core_app_preferences_tests` covers UI scale/font-scale planning,
+  scale-option selection, viewport scale planning, RTL direction planning,
+  timelapse start/stop/no-op decisions, simple stored preferences, and
+  `AppPreferenceServices` execution dispatch for options-menu side effects.
 - `pp_platform_api_tests` covers service dispatch for clipboard read/write,
   empty clipboard writes, cursor visibility, virtual-keyboard visibility,
   external file display, file sharing, and picker callbacks without platform

docs/modernization/debt.md

@@ -62,6 +62,7 @@ agent or engineer to remove them without reconstructing context from chat.
 | DEBT-0042 | Open | Modernization | Accepted Save As and Save Version planning/execution dispatch now consumes pure `pp_app_core` through `App::dialog_save`, `App::dialog_save_ver`, `pano_cli plan-document-file`, `pano_cli plan-document-version`, `DocumentFileSaveServices`, `DocumentVersionSaveServices`, and `src/legacy_document_session_services.*`, but the bridge still opens legacy overwrite prompts, calls legacy `Canvas::project_save`, mutates app document name/path/directory fields, marks version saves dirty before saving, updates the title, and handles keyboard/dialog cleanup directly | Preserve current Save As and Save Version behavior while document persistence moves toward app/document/storage/UI services | `pp_app_core_document_session_tests`; `pano_cli plan-document-file --work-dir D:/Paint --name demo --target-exists`; `pano_cli plan-document-version --directory D:/Paint --doc-name demo.01 --existing-path D:/Paint/demo.02.ppi`; `pano_cli simulate-app-session --save-intent save-as`; `pano_cli simulate-app-session --save-intent save-version`; `ctest --preset desktop-fast --build-config Debug` | Save As overwrite prompting, project-save execution, app document metadata updates, title updates, version-save dirty-state handling, and keyboard/dialog cleanup are owned by injected app/document/storage/UI services with `App::dialog_save` and `App::dialog_save_ver` acting only as UI adapters |
 | DEBT-0043 | Open | Modernization | Equirectangular, layer, animation-frame, depth, and cube-face export planning/execution dispatch now consumes pure `pp_app_core` through `App::dialog_export`, `App::dialog_export_layers`, `App::dialog_export_anim_frames`, `App::dialog_export_depth`, `App::dialog_export_cube_faces`, `pano_cli plan-export-*`, `DocumentExportServices`, and `src/legacy_document_export_services.*`, but the bridge still calls legacy `Canvas` export methods, owns platform-specific export success messages, creates export directories, handles picker-selected stems, and performs Web prepared-file handoff directly | Preserve current image/collection/depth/cube export behavior while export execution moves toward document/renderer/platform/storage services | `pp_app_core_document_export_tests`; `pano_cli plan-export-start --requires-license --demo`; `pano_cli plan-export-menu --kind layers`; `pano_cli plan-export-target --kind collection --work-dir D:/Paint --doc-name demo --suffix _layers`; `pano_cli simulate-document-export`; `ctest --preset desktop-fast --build-config Debug` | File, collection, stem, depth, and cube export execution, export-directory creation, platform success reporting, Web file handoff, and legacy canvas export calls are owned by injected document/renderer/platform/storage services with export dialogs acting only as UI adapters |
 | DEBT-0044 | Open | Modernization | Timelapse and animation MP4 export execution dispatch now consumes pure `pp_app_core` through `App::dialog_timelapse_export`, `App::dialog_export_mp4`, `pano_cli plan-export-menu`, `pano_cli plan-export-target --kind name`, `DocumentVideoExportServices`, and `src/legacy_document_export_services.*`, but the bridge still launches legacy desktop timelapse worker threads, calls `App::rec_export`, calls `Canvas::export_anim_mp4`, owns mobile/Web save callbacks, and emits success messages directly | Preserve current MP4/timelapse export behavior while video export moves toward app/document/renderer/video/platform/storage services | `pp_app_core_document_export_tests`; `pano_cli plan-export-menu --kind animation-mp4`; `pano_cli plan-export-menu --kind timelapse`; `pano_cli plan-export-target --kind name --doc-name demo --suffix -animation`; `pano_cli plan-export-target --kind name --doc-name demo --suffix -timelapse`; `ctest --preset desktop-fast --build-config Debug` | Timelapse and animation MP4 execution, desktop worker threading, frame readback/video encoding handoff, mobile/Web save callbacks, and success reporting are owned by injected app/document/renderer/video/platform/storage services with export dialogs acting only as UI adapters |
+| DEBT-0045 | Open | Modernization | Options-menu preference execution now consumes pure `pp_app_core` through UI scale, viewport scale, RTL direction, VR-controller, auto-timelapse, and canvas cursor-mode callbacks plus `AppPreferenceServices` and `src/legacy_app_preference_services.*`, but the bridge still calls legacy `App::set_ui_scale`, `App::set_ui_rtl`, `NodeCanvas::set_density`, `NodeCanvas::set_cursor_visibility`, `App::rec_start`, `App::rec_stop`, and `Settings::save` directly | Preserve current options-menu behavior while preferences move toward app/UI/platform/storage services | `pp_app_core_app_preferences_tests`; `pano_cli plan-app-preferences --ui-scale 1.5 --display-density 2 --current-scale 1.6 --scale-option 1 --scale-option 1.5 --rtl`; `ctest --preset desktop-fast --build-config Debug`; `cmake --build --preset windows-msvc-default --config Debug --target PanoPainter` | Preference persistence, UI/layout direction, viewport density, cursor mode, VR-controller state, and auto-timelapse recording side effects are owned by injected app/UI/platform/storage services with options-menu callbacks acting only as UI adapters |
 
 ## Closed Debt
 

docs/modernization/roadmap.md

@@ -179,7 +179,10 @@ contracts while legacy canvas/project loading remains in place.
 scale option selection, viewport scale, RTL layout direction, timelapse
 recording toggles, VR controller enablement, and canvas cursor mode;
 the live tools/options menu and `pano_cli plan-app-preferences` consume those
-contracts while legacy widgets and settings persistence execute them.
+contracts. Options-menu preference execution now dispatches through
+`AppPreferenceServices` and `src/legacy_app_preference_services.*` before
+legacy widgets, settings persistence, recording toggles, and canvas cursor
+updates continue.
 It also owns tested app status/display plans for document title text,
 resolution mapping/labels, DPI text, history-memory text, and recording-frame
 status text, plus renderer diagnostic indicator labels for framebuffer fetch
@@ -602,6 +605,11 @@ dispatch through `ToolsMenuServices` in the shared app-shell bridge before the
 legacy UI/panel/canvas/platform adapters continue execution. The live animation
 panel route now also checks animation panel visibility and applies animation
 panel layout state instead of using the grid panel by mistake.
+Options-menu preference callbacks now dispatch UI scale, viewport scale, RTL,
+VR-controller, auto-timelapse, and cursor-mode side effects through
+`AppPreferenceServices` in `src/legacy_app_preference_services.*` before
+retained settings writes, recording lifecycle calls, and legacy canvas/UI
+adapters continue.
 `pano_cli plan-about-menu` exposes app-core planning for About menu help,
 about, what's-new, crash-test, and performance-test commands, including
 versioned what's-new labels, diagnostic gating, and no-canvas performance-test
@@ -1345,6 +1353,11 @@ Results:
   `pp_app_core_document_export_tests`, `pano_cli_plan_export_menu_*`,
   `pano_cli_plan_export_target_name_smoke`, and
   `pano_cli_simulate_document_export_smoke`.
+- `PanoPainter`, `pp_app_core_app_preferences_tests`, and `pano_cli` built
+  after options-menu preference execution moved behind app preference services.
+- Focused preference CTest coverage passed for
+  `pp_app_core_app_preferences_tests` and the app-preferences CLI smoke tests
+  after the live bridge split.
 - `pp_app_core_document_recording_tests` passed, covering recording start/stop,
   clear, platform recorded-file cleanup, frame-count reset, export progress
   totals, and oversized progress-total clamping.