From f88b2094ef98bb8b0d62c28e8c12debdaec8e7be Mon Sep 17 00:00:00 2001 From: omigamedev Date: Mon, 15 Jun 2026 22:38:03 +0200 Subject: [PATCH] Record open legacy project result closeout --- docs/modernization/debt.md | 6 ++++++ docs/modernization/roadmap.md | 4 ++++ docs/modernization/tasks.md | 36 +++++++++++++++++++++++++++++++++++ 3 files changed, 46 insertions(+) diff --git a/docs/modernization/debt.md b/docs/modernization/debt.md index 89dca492..81f0bbb1 100644 --- a/docs/modernization/debt.md +++ b/docs/modernization/debt.md @@ -70,6 +70,12 @@ agent or engineer to remove them without reconstructing context from chat. instead of living inline in the retained document-open service method; the remaining document-open bridge debt stays concentrated in project-open execution, layer refresh, title updates, and retained history services. +- 2026-06-15: `DEBT-0039` was narrowed again. The retained project-open + success/failure handling in `open_legacy_project()` now routes through a + focused helper in `src/legacy_document_open_services.cpp` instead of living + inline in the retained document-open helper; the remaining document-open + bridge debt stays concentrated in layer refresh, title updates, and retained + history services. - 2026-06-15: `DEBT-0038` was narrowed again. The retained cloud downloaded- project open camera reset and layer-clear setup in `execute_legacy_downloaded_project_open()` now routes through a focused diff --git a/docs/modernization/roadmap.md b/docs/modernization/roadmap.md index c4a8c949..87315735 100644 --- a/docs/modernization/roadmap.md +++ b/docs/modernization/roadmap.md @@ -1400,6 +1400,10 @@ The retained unsaved-project discard prompt wiring in through a focused helper, so the remaining document-open bridge debt is further concentrated on project-open execution, layer refresh, title updates, and retained history services. +The retained project-open success/failure handling in `open_legacy_project()` +now also routes through a focused helper, so the remaining document-open +bridge debt is further concentrated on layer refresh, title updates, and +retained history services. `App::request_close`, `App::save_document`, and `App::continue_document_workflow_after_optional_save` now route through app-core document-session executors and `src/legacy_document_session_services.*`, diff --git a/docs/modernization/tasks.md b/docs/modernization/tasks.md index 40bb7a8e..1438e574 100644 --- a/docs/modernization/tasks.md +++ b/docs/modernization/tasks.md @@ -1703,6 +1703,42 @@ Completed Task Log: | --- | --- | ---: | --- | --- | | 2026-06-15 | ADP-045 | no score movement | `powershell -ExecutionPolicy Bypass -File scripts\\automation\\quiet-validate.ps1 -BuildTargets pano_cli -TestRegex "pp_app_core_document_route|pp_app_core_document_session"` | `39728e46` | +### ADP-046 - Extract Document-Open Project Result Helper + +Status: Done +Score: no score movement +Debt: `DEBT-0039` +Scope: `src/legacy_document_open_services.cpp` only + +Closeout: `7b8da2f0` + +Goal: + +Reduce the inline retained project-open success/failure handling surface by +extracting the callback body from `open_legacy_project()` into a focused helper +while preserving current behavior. + +Done Checks: + +- The retained project-open success/failure handling no longer lives inline in + `open_legacy_project()`. +- The retained project-open result path now routes through a focused helper in + `src/legacy_document_open_services.cpp`. +- `DEBT-0039` and the roadmap note the reduced remaining document-open bridge + surface. + +Validation: + +```powershell +powershell -ExecutionPolicy Bypass -File scripts\\automation\\quiet-validate.ps1 -BuildTargets pano_cli -TestRegex "pp_app_core_document_route|pp_app_core_document_session" +``` + +Completed Task Log: + +| Date | Task | Score | Validation | Commit | +| --- | --- | ---: | --- | --- | +| 2026-06-15 | ADP-046 | no score movement | `powershell -ExecutionPolicy Bypass -File scripts\\automation\\quiet-validate.ps1 -BuildTargets pano_cli -TestRegex "pp_app_core_document_route|pp_app_core_document_session"` | `7b8da2f0` | + ### RND-001 - Make Pure Equirectangular Export The Primary Success Path Status: Done