Extract layer operation planning
This commit is contained in:
@@ -38,7 +38,7 @@ agent or engineer to remove them without reconstructing context from chat.
|
||||
| DEBT-0017 | Open | Modernization | Startup storage path preparation, `App::clipboard_get_text`, `App::clipboard_set_text`, `App::show_cursor`, `App::hide_cursor`, `App::showKeyboard`, `App::hideKeyboard`, `App::display_file`, `App::share_file`, native app/window close, UI-thread lifecycle hooks, render-context acquire/release/present hooks, render-target binding hooks, render platform hint hooks, render debug callback hooks, render-capture frame hooks, recording cleanup, live asset/layout reload policy, diagnostic stacktrace/crash hooks, per-frame platform hooks, `App::pick_image`, `App::pick_file`, the non-writer `App::pick_file_save`, `App::pick_dir`, and prepared-file save/download handoff now call the SDK-free `pp::platform::PlatformServices` interface, and Windows injects `WindowsPlatformServices` from `src/platform_windows/windows_platform_services.*`; non-Windows live implementations still use `src/platform_legacy/legacy_platform_services.*`, a named fallback adapter that forwards to retained Apple/Android/Linux/Web bridge functions and retained no-op branches | Preserve behavior while moving platform execution behind a testable service boundary before platform shell implementations are injected | `pp_platform_api_tests`; `pp_app_core_document_platform_io_tests`; `ctest --preset desktop-fast --build-config Debug`; `powershell -ExecutionPolicy Bypass -File scripts\automation\package-smoke.ps1 -Preset windows-msvc-default -Configuration Debug` | Replace `src/platform_legacy/legacy_platform_services.*` with injected `pp_platform_*` service implementations owned by each non-Windows platform shell |
|
||||
| DEBT-0019 | Open | Modernization | MSVC warning C4100 is muted globally through `pp_project_warnings` with `/wd4100` | Legacy callbacks, virtual hooks, serializer methods, and platform/API compatibility functions carry many intentionally unused parameters during the component split; muting this keeps stricter warning builds focused on higher-signal migration issues | `cmake --build --preset windows-msvc-default --config Debug --target PanoPainter`; `ctest --preset desktop-fast --build-config Debug` | Remove `/wd4100`, mark intentionally unused parameters with names/comments or `[[maybe_unused]]`, and make the Windows app and headless tests pass without C4100 warnings |
|
||||
| DEBT-0020 | Open | Modernization | Document resize dialog state and selected-resolution planning now consume pure `pp_app_core` through `NodeDialogResize`, `App::dialog_resize`, and `pano_cli plan-document-resize`, but live resize execution still calls legacy `Canvas::resize` and clears legacy `ActionManager` history directly | Preserve existing layer/frame GPU resize behavior while the document model and canvas execution boundary are extracted incrementally | `pp_app_core_document_resize_tests`; `pano_cli plan-document-resize --current-resolution 2048 --selected-resolution-index 4`; `ctest --preset desktop-fast --build-config Debug` | Document resize execution is owned by a document/app boundary with legacy `Canvas` acting only as an adapter or removed entirely |
|
||||
| DEBT-0021 | Open | Modernization | Layer rename planning now consumes pure `pp_app_core` through `App::dialog_layer_rename` and `pano_cli plan-layer-rename`, but live rename execution still mutates legacy `Canvas` layer state, `NodeLayer`, and `ActionManager` undo entries directly | Preserve existing UI/canvas behavior while document layer commands and undo history are extracted incrementally | `pp_app_core_document_layer_tests`; `pano_cli plan-layer-rename --old-name Base --new-name Paint`; `ctest --preset desktop-fast --build-config Debug` | Layer rename execution is owned by the document/app command boundary with legacy `Canvas`/UI nodes acting only as adapters or removed entirely |
|
||||
| DEBT-0021 | Open | Modernization | Layer rename and layer panel operation planning now consume pure `pp_app_core` through `App::dialog_layer_rename`, `App::init_sidebar` layer callbacks, `pano_cli plan-layer-rename`, and `pano_cli plan-layer-operation`, but live execution still mutates legacy `Canvas` layer state, `NodeLayer`/`NodePanelLayer`, and `ActionManager` undo entries directly | Preserve existing UI/canvas behavior while document layer commands and undo history are extracted incrementally | `pp_app_core_document_layer_tests`; `pano_cli plan-layer-rename --old-name Base --new-name Paint`; `pano_cli plan-layer-operation --kind add --layer-count 2 --index 1 --name Paint`; `ctest --preset desktop-fast --build-config Debug` | Layer command execution is owned by the document/app command boundary with legacy `Canvas`/UI nodes acting only as adapters or removed entirely |
|
||||
|
||||
## Closed Debt
|
||||
|
||||
|
||||
@@ -250,7 +250,8 @@ Implementation tasks:
|
||||
|
||||
- Set C++23 through target features, not raw compiler flags.
|
||||
- Add warning profiles:
|
||||
- MSVC: `/W4 /permissive- /Zc:__cplusplus /Zc:preprocessor`.
|
||||
- MSVC: `/W4 /permissive- /Zc:__cplusplus /Zc:preprocessor`, with
|
||||
`C4100` muted temporarily under `DEBT-0019`.
|
||||
- Optional MSVC analysis preset: `/analyze`.
|
||||
- Clang/GCC: `-Wall -Wextra -Wpedantic -Wconversion -Wshadow
|
||||
-Wnull-dereference`.
|
||||
@@ -289,7 +290,8 @@ Gate:
|
||||
|
||||
- Desktop library targets compile with strict diagnostics.
|
||||
- New warnings caused by refactor are fixed or locally justified.
|
||||
- No global blanket warning suppression for project code.
|
||||
- Any global warning suppression must have an open debt entry, validation
|
||||
command, and removal condition.
|
||||
|
||||
## Phase 3: Test Harness And Agent-Ready Automation
|
||||
|
||||
@@ -484,6 +486,10 @@ legacy `Canvas` resize execution and `ActionManager` history clearing continue.
|
||||
`pano_cli plan-layer-rename` exposes the app-core layer rename decision used by
|
||||
the live layer rename dialog before legacy `Canvas` layer mutation and
|
||||
`ActionManager` undo wiring continue.
|
||||
`pano_cli plan-layer-operation` exposes app-core planning for layer add,
|
||||
duplicate, select, reorder, remove, opacity, visibility, alpha-lock, blend-mode,
|
||||
and highlight actions used by the live layer panel before legacy `Canvas` and
|
||||
UI layer execution continue.
|
||||
`pp_platform_api` now owns a headless `PlatformServices` interface for
|
||||
startup storage path preparation, clipboard text, cursor visibility,
|
||||
virtual-keyboard visibility, UI-thread lifecycle hooks, render-context
|
||||
@@ -1091,11 +1097,19 @@ Results:
|
||||
`pano_cli_plan_document_resize_rejects_invalid_selection` passed and expose
|
||||
live document-resize planning as JSON automation.
|
||||
- `pp_app_core_document_layer_tests` passed, covering changed layer rename,
|
||||
unchanged no-op rename, empty-name rejection, and overlong-name rejection.
|
||||
unchanged no-op rename, empty-name rejection, overlong-name rejection, layer
|
||||
add/duplicate/select/reorder/remove planning, metadata planning, bad-index
|
||||
rejection, bad-opacity rejection, bad-blend-mode rejection, and transient
|
||||
highlight behavior.
|
||||
- `pano_cli_plan_layer_rename_smoke`,
|
||||
`pano_cli_plan_layer_rename_no_op_smoke`, and
|
||||
`pano_cli_plan_layer_rename_rejects_empty_name` passed and expose live
|
||||
layer-rename planning as JSON automation.
|
||||
- `pano_cli_plan_layer_operation_add_smoke`,
|
||||
`pano_cli_plan_layer_operation_reorder_no_op_smoke`,
|
||||
`pano_cli_plan_layer_operation_highlight_smoke`, and
|
||||
`pano_cli_plan_layer_operation_rejects_bad_opacity` passed and expose live
|
||||
layer-panel operation planning as JSON automation.
|
||||
- `pp_app_core_document_sharing_tests` passed, covering saved-path gating before
|
||||
platform share execution.
|
||||
- `pano_cli_plan_share_file_unsaved_smoke` and
|
||||
|
||||
Reference in New Issue
Block a user