omar/panopainter
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Extract layer operation planning

Browse Source
This commit is contained in:
omigamedev
2026-06-03 10:20:37 +02:00
parent 07ed23c2d1
commit fdc1defaba
7 changed files with 752 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
tests/CMakeLists.txt
View File

@@ -718,6 +718,30 @@ if(TARGET pano_cli)
LABELS "app;integration;desktop-fast;fuzz"
WILL_FAIL TRUE)
add_test(NAME pano_cli_plan_layer_operation_add_smoke
COMMAND pano_cli plan-layer-operation --kind add --layer-count 2 --index 1 --name Paint)
set_tests_properties(pano_cli_plan_layer_operation_add_smoke PROPERTIES
LABELS "app;integration;desktop-fast"
PASS_REGULAR_EXPRESSION "\"command\":\"plan-layer-operation\".*\"operation\":\"add\".*\"insertIndex\":1.*\"name\":\"Paint\".*\"marksUnsaved\":true.*\"reloadsAnimationLayers\":true")
add_test(NAME pano_cli_plan_layer_operation_reorder_no_op_smoke
COMMAND pano_cli plan-layer-operation --kind reorder --layer-count 3 --from-index 1 --to-index 1)
set_tests_properties(pano_cli_plan_layer_operation_reorder_no_op_smoke PROPERTIES
LABELS "app;integration;desktop-fast;fuzz"
PASS_REGULAR_EXPRESSION "\"command\":\"plan-layer-operation\".*\"operation\":\"reorder\".*\"fromIndex\":1.*\"toIndex\":1.*\"mutatesDocument\":false.*\"marksUnsaved\":false")
add_test(NAME pano_cli_plan_layer_operation_highlight_smoke
COMMAND pano_cli plan-layer-operation --kind highlight --layer-count 2 --index 1 --enabled)
set_tests_properties(pano_cli_plan_layer_operation_highlight_smoke PROPERTIES
LABELS "app;integration;desktop-fast"
PASS_REGULAR_EXPRESSION "\"command\":\"plan-layer-operation\".*\"operation\":\"set-highlight\".*\"index\":1.*\"flag\":true.*\"mutatesDocument\":false.*\"updatesTitle\":false")
add_test(NAME pano_cli_plan_layer_operation_rejects_bad_opacity
COMMAND pano_cli plan-layer-operation --kind opacity --layer-count 2 --index 1 --opacity 1.5)
set_tests_properties(pano_cli_plan_layer_operation_rejects_bad_opacity PROPERTIES
LABELS "app;integration;desktop-fast;fuzz"
WILL_FAIL TRUE)
add_test(NAME pano_cli_plan_share_file_unsaved_smoke
COMMAND pano_cli plan-share-file)
set_tests_properties(pano_cli_plan_share_file_unsaved_smoke PROPERTIES

133
tests/app_core/document_layer_tests.cpp
View File

@@ -1,6 +1,7 @@
#include "app_core/document_layer.h"
#include "test_harness.h"
#include <cmath>
#include <string>
namespace {
@@ -50,6 +51,133 @@ void layer_rename_rejects_overlong_name(pp::tests::Harness& harness)
}
}
void layer_add_validates_insert_index_and_name(pp::tests::Harness& harness)
{
const auto plan = pp::app::plan_document_layer_add(2, 1, "Paint");
PP_EXPECT(harness, plan);
if (plan) {
PP_EXPECT(harness, plan.value().operation == pp::app::DocumentLayerOperation::add);
PP_EXPECT(harness, plan.value().insert_index == 1);
PP_EXPECT(harness, plan.value().name == "Paint");
PP_EXPECT(harness, plan.value().marks_unsaved);
PP_EXPECT(harness, plan.value().reloads_animation_layers);
}
PP_EXPECT(harness, !pp::app::plan_document_layer_add(2, -1, "Paint"));
PP_EXPECT(harness, !pp::app::plan_document_layer_add(2, 3, "Paint"));
PP_EXPECT(harness, !pp::app::plan_document_layer_add(2, 1, ""));
}
void layer_duplicate_select_and_reorder_validate_indices(pp::tests::Harness& harness)
{
const auto duplicate = pp::app::plan_document_layer_duplicate(3, 1);
PP_EXPECT(harness, duplicate);
if (duplicate) {
PP_EXPECT(harness, duplicate.value().source_index == 1);
PP_EXPECT(harness, duplicate.value().insert_index == 2);
PP_EXPECT(harness, duplicate.value().marks_unsaved);
}
const auto select = pp::app::plan_document_layer_select(3, 2);
PP_EXPECT(harness, select);
if (select) {
PP_EXPECT(harness, select.value().index == 2);
PP_EXPECT(harness, !select.value().marks_unsaved);
PP_EXPECT(harness, select.value().reloads_animation_layers);
}
const auto reorder = pp::app::plan_document_layer_reorder(3, 2, 0);
PP_EXPECT(harness, reorder);
if (reorder) {
PP_EXPECT(harness, reorder.value().from_index == 2);
PP_EXPECT(harness, reorder.value().to_index == 0);
PP_EXPECT(harness, reorder.value().marks_unsaved);
}
const auto no_op_reorder = pp::app::plan_document_layer_reorder(3, 1, 1);
PP_EXPECT(harness, no_op_reorder);
if (no_op_reorder) {
PP_EXPECT(harness, !no_op_reorder.value().mutates_document);
PP_EXPECT(harness, !no_op_reorder.value().marks_unsaved);
}
PP_EXPECT(harness, !pp::app::plan_document_layer_duplicate(3, 3));
PP_EXPECT(harness, !pp::app::plan_document_layer_select(3, -1));
PP_EXPECT(harness, !pp::app::plan_document_layer_reorder(3, 0, 3));
}
void layer_remove_keeps_at_least_one_layer(pp::tests::Harness& harness)
{
const auto plan = pp::app::plan_document_layer_remove(2, 0);
PP_EXPECT(harness, plan);
if (plan) {
PP_EXPECT(harness, plan.value().operation == pp::app::DocumentLayerOperation::remove);
PP_EXPECT(harness, plan.value().index == 0);
PP_EXPECT(harness, plan.value().marks_unsaved);
PP_EXPECT(harness, plan.value().reloads_animation_layers);
}
PP_EXPECT(harness, !pp::app::plan_document_layer_remove(1, 0));
PP_EXPECT(harness, !pp::app::plan_document_layer_remove(2, 2));
}
void layer_metadata_plans_validate_values(pp::tests::Harness& harness)
{
const auto opacity = pp::app::plan_document_layer_opacity(2, 1, 0.25F);
PP_EXPECT(harness, opacity);
if (opacity) {
PP_EXPECT(harness, opacity.value().operation == pp::app::DocumentLayerOperation::set_opacity);
PP_EXPECT(harness, opacity.value().opacity == 0.25F);
PP_EXPECT(harness, opacity.value().marks_unsaved);
PP_EXPECT(harness, !opacity.value().reloads_animation_layers);
}
const auto visibility = pp::app::plan_document_layer_visibility(2, 1, false);
PP_EXPECT(harness, visibility);
if (visibility) {
PP_EXPECT(harness, visibility.value().operation == pp::app::DocumentLayerOperation::set_visibility);
PP_EXPECT(harness, !visibility.value().flag);
PP_EXPECT(harness, visibility.value().reloads_animation_layers);
}
const auto alpha_lock = pp::app::plan_document_layer_alpha_lock(2, 1, true);
PP_EXPECT(harness, alpha_lock);
if (alpha_lock) {
PP_EXPECT(harness, alpha_lock.value().operation == pp::app::DocumentLayerOperation::set_alpha_lock);
PP_EXPECT(harness, alpha_lock.value().flag);
}
const auto blend = pp::app::plan_document_layer_blend_mode(2, 1, 4);
PP_EXPECT(harness, blend);
if (blend) {
PP_EXPECT(harness, blend.value().operation == pp::app::DocumentLayerOperation::set_blend_mode);
PP_EXPECT(harness, blend.value().blend_mode == 4);
}
PP_EXPECT(harness, !pp::app::plan_document_layer_opacity(2, 1, -0.1F));
PP_EXPECT(harness, !pp::app::plan_document_layer_opacity(2, 1, 1.1F));
PP_EXPECT(harness, !pp::app::plan_document_layer_opacity(2, 1, std::nanf("")));
PP_EXPECT(harness, !pp::app::plan_document_layer_blend_mode(2, 1, -1));
PP_EXPECT(harness, !pp::app::plan_document_layer_blend_mode(2, 1, 5));
PP_EXPECT(harness, !pp::app::plan_document_layer_visibility(2, 2, true));
PP_EXPECT(harness, !pp::app::plan_document_layer_alpha_lock(2, 2, true));
}
void layer_highlight_is_transient(pp::tests::Harness& harness)
{
const auto plan = pp::app::plan_document_layer_highlight(2, 1, true);
PP_EXPECT(harness, plan);
if (plan) {
PP_EXPECT(harness, plan.value().operation == pp::app::DocumentLayerOperation::set_highlight);
PP_EXPECT(harness, plan.value().flag);
PP_EXPECT(harness, !plan.value().mutates_document);
PP_EXPECT(harness, !plan.value().marks_unsaved);
PP_EXPECT(harness, !plan.value().updates_title);
}
PP_EXPECT(harness, !pp::app::plan_document_layer_highlight(2, 2, true));
}
}
int main()
@@ -59,5 +187,10 @@ int main()
harness.run("layer rename ignores unchanged name", layer_rename_ignores_unchanged_name);
harness.run("layer rename rejects empty name", layer_rename_rejects_empty_name);
harness.run("layer rename rejects overlong name", layer_rename_rejects_overlong_name);
harness.run("layer add validates insert index and name", layer_add_validates_insert_index_and_name);
harness.run("layer duplicate select and reorder validate indices", layer_duplicate_select_and_reorder_validate_indices);
harness.run("layer remove keeps at least one layer", layer_remove_keeps_at_least_one_layer);
harness.run("layer metadata plans validate values", layer_metadata_plans_validate_values);
harness.run("layer highlight is transient", layer_highlight_is_transient);
return harness.finish();
}