Extract cloud browser dialog helper
This commit is contained in:
@@ -18,6 +18,12 @@ agent or engineer to remove them without reconstructing context from chat.
|
||||
|
||||
## Recent Reductions
|
||||
|
||||
- 2026-06-15: `DEBT-0038` was narrowed again. The retained cloud browser
|
||||
dialog creation path in `LegacyCloudServices::show_browser()` now routes
|
||||
through a focused helper in `src/legacy_cloud_services.cpp` instead of
|
||||
living inline in the retained service method; the remaining cloud bridge
|
||||
debt stays concentrated in retained prompt/progress lifetime, OpenGL
|
||||
context guarding, and the still-retained transfer-thread execution model.
|
||||
- 2026-06-15: `DEBT-0038` was narrowed again. The retained cloud publish
|
||||
prompt path in `LegacyCloudServices::prompt_publish()` now routes through a
|
||||
focused helper in `src/legacy_cloud_services.cpp` instead of living inline
|
||||
|
||||
@@ -172,6 +172,11 @@ The retained cloud publish prompt path in
|
||||
helper in `src/legacy_cloud_services.cpp`, so the remaining cloud bridge debt
|
||||
is further concentrated on retained prompt/progress lifetime, OpenGL context
|
||||
guarding, and the still-retained transfer-thread execution model.
|
||||
The retained cloud browser dialog creation path in
|
||||
`LegacyCloudServices::show_browser()` now also routes through a focused helper
|
||||
in `src/legacy_cloud_services.cpp`, so the remaining cloud bridge debt is
|
||||
further concentrated on retained prompt/progress lifetime, OpenGL context
|
||||
guarding, and the still-retained transfer-thread execution model.
|
||||
|
||||
Recent 2026-06-13 retained preview reductions continue to narrow DEBT-0036:
|
||||
`NodeStrokePreview::draw_stroke_immediate()` now also routes
|
||||
|
||||
@@ -979,6 +979,40 @@ Completed Task Log:
|
||||
| Date | Task | Score | Validation | Commit |
|
||||
| --- | --- | ---: | --- | --- |
|
||||
| 2026-06-15 | ADP-025 | no score movement | `MSBuild.exe out\build\windows-msvc-default\panopainter_app.vcxproj /p:Configuration=Debug /p:Platform=x64`; `ctest --preset desktop-fast --build-config Debug -R "pp_app_core_document_cloud" --output-on-failure` | `777579ff` |
|
||||
|
||||
### ADP-026 - Extract Cloud Browser Dialog Helper
|
||||
|
||||
Status: Done
|
||||
Score: no score movement
|
||||
Debt: `DEBT-0038`
|
||||
Scope: `src/legacy_cloud_services.cpp` only
|
||||
|
||||
Goal:
|
||||
|
||||
Reduce the inline retained cloud browser dialog surface by extracting
|
||||
the dialog creation path from `LegacyCloudServices::show_browser()`
|
||||
into a focused helper while preserving current behavior.
|
||||
|
||||
Done Checks:
|
||||
|
||||
- The retained cloud browser dialog creation path no longer lives inline in
|
||||
`LegacyCloudServices::show_browser()`.
|
||||
- The retained cloud browser dialog creation path now routes through a
|
||||
focused helper in `src/legacy_cloud_services.cpp`.
|
||||
- `DEBT-0038` and the roadmap note the reduced remaining cloud bridge
|
||||
surface.
|
||||
|
||||
Validation:
|
||||
|
||||
```powershell
|
||||
& 'C:\Program Files\Microsoft Visual Studio\18\Community\MSBuild\Current\Bin\MSBuild.exe' out\build\windows-msvc-default\panopainter_app.vcxproj /p:Configuration=Debug /p:Platform=x64
|
||||
ctest --preset desktop-fast --build-config Debug -R "pp_app_core_document_cloud" --output-on-failure
|
||||
```
|
||||
|
||||
Completed Task Log:
|
||||
|
||||
| Date | Task | Score | Validation | Commit |
|
||||
| --- | --- | ---: | --- | --- |
|
||||
| 2026-06-15 | ADP-007 | +1 legacy adapter retirement | `ctest --preset desktop-fast --build-config Debug -R "pp_app_core_app_dialog\|pp_ui_core_node_lifetime\|pp_ui_core_overlay_lifetime" --output-on-failure`; `ctest --preset desktop-fast --build-config Debug -R "pp_app_core_main_toolbar" --output-on-failure`; `MSBuild.exe out\build\windows-msvc-default\tests\pp_app_core_main_toolbar_tests.vcxproj /p:Configuration=Debug /p:Platform=x64`; `MSBuild.exe out\build\windows-msvc-default\panopainter_app.vcxproj /p:Configuration=Debug /p:Platform=x64` | `8db859cb` |
|
||||
|
||||
### RND-001 - Make Pure Equirectangular Export The Primary Success Path
|
||||
|
||||
Reference in New Issue
Block a user