Own log worker and trim Apple platform hooks

This commit is contained in:
2026-06-16 07:49:03 +02:00
parent 0c72aa0312
commit 7ef399eb75
10 changed files with 104 additions and 22 deletions

View File

@@ -18,6 +18,22 @@ agent or engineer to remove them without reconstructing context from chat.
## Reductions
- 2026-06-16: `DEBT-0036` was narrowed again. `NodeCanvas` cache-to-screen
checkerboard-plane callback setup now routes through
`make_legacy_canvas_draw_merge_cache_to_screen_checkerboard_plane(...)` in
`src/legacy_canvas_draw_merge_services.h` instead of building the full MVP
callback body inline in `NodeCanvas::draw()`; broader canvas draw
orchestration remains.
- 2026-06-16: `DEBT-0003` was narrowed again. `LogRemote` now owns its network
logging worker as `std::jthread` with explicit stop requests in `src/log.*`
instead of raw `std::thread` ownership; retained global logger singleton,
network logging policy, and queue execution remain.
- 2026-06-16: `DEBT-0017` was narrowed again. Apple crash-test, app-close, and
iOS SonarPen hooks now route through explicit bridge callbacks in
`src/platform_apple/apple_platform_services.*` consumed by
`src/platform_legacy/legacy_platform_services.cpp` instead of direct `App::I`
calls in those legacy platform methods; the retained Apple fallback adapter
and broader platform singleton reach remain.
- 2026-06-16: `DEBT-0036` was narrowed again. `NodeCanvas` merged-path and
non-blend checkerboard background setup now route through
`execute_legacy_canvas_draw_merge_background_setup(...)` in

View File

@@ -100,7 +100,7 @@ Current architecture mismatches that must be treated as real blockers:
remain, even though iOS keyboard visibility and prepared-file save handoff
now also route through explicit Apple bridge callbacks and Apple render-
context hooks plus iOS main-render-target binding now route through the same
bridge style.
bridge style, as do Apple crash-test, app-close, and iOS SonarPen hooks.
- `src/platform_legacy/legacy_platform_services.*` is still part of the live
app shell.
- `pp_panopainter_ui` still depends on `pp_legacy_app`.
@@ -108,7 +108,8 @@ Current architecture mismatches that must be treated as real blockers:
OpenGL execution around the renderer boundary, even though `NodeCanvas`
display resolve, cache-to-screen composite, post-draw mask/grid/current-mode
sequencing, per-layer/per-plane retained draw execution, and shared
checkerboard background setup now route through retained draw-merge helpers.
checkerboard background setup now route through retained draw-merge helpers,
with the cache-to-screen checkerboard-plane callback setup also reduced.
- `app_layout.cpp` and `app_dialogs.cpp` are still mixed shell/controller files
rather than thin composition/binding surfaces.
- `App`, `Canvas`, `Node`, retained workers, and platform entrypoints still use
@@ -118,7 +119,8 @@ Current architecture mismatches that must be treated as real blockers:
launches now use owned `std::jthread` or service-owned worker queues and
`AppRuntime` now owns render/UI workers with explicit `std::jthread`
shutdown semantics while the Windows splash-dialog and HMD renderer workers
also use owned `std::jthread` lifecycle.
also use owned `std::jthread` lifecycle and `LogRemote` now uses the same
ownership model.
- Modern C++23 usage exists in extracted components, especially `std::span`,
explicit result/status objects, and a few concepts, but the live app still
does not consistently express ownership, thread affinity, or renderer

View File

@@ -133,6 +133,8 @@ Current slice:
node still owns most live-pass and retained GL resource execution.
- `NodeCanvas` merged-path and non-blend checkerboard background setup now also
route through `execute_legacy_canvas_draw_merge_background_setup(...)`.
- `NodeCanvas` cache-to-screen checkerboard-plane callback setup now also routes
through a retained helper in `legacy_canvas_draw_merge_services.h`.
- `NodeCanvas` display resolve plus cache-to-screen checkerboard/cache-texture
composite now route through `legacy_canvas_draw_merge_services.h`.
- `NodeCanvas` smoothing-mask overlay, smoothing-mask face pass, grid keepalive
@@ -375,6 +377,8 @@ Current slice:
- Windows splash-dialog and HMD renderer worker ownership in `main.cpp` now
also use `std::jthread` with explicit stop requests instead of raw
`std::thread`
- `LogRemote` worker ownership in `src/log.*` now also uses `std::jthread`
with explicit stop requests instead of raw `std::thread`
- brush package import/export now use service-owned `std::jthread` workers and
UI-thread completion handoff
- prepared-file save work and grid lightmap launch now also use service-owned
@@ -593,6 +597,9 @@ Current slice:
- Apple render-context acquire/release/present hooks and iOS
`bind_main_render_target()` now also route through explicit Apple bridge
callbacks instead of direct `App::I` calls in `LegacyPlatformServices`
- Apple crash-test, app-close, and iOS SonarPen hooks now also route through
explicit Apple bridge callbacks instead of direct `App::I` calls in
`LegacyPlatformServices`
- retained Apple callback injection and broader `platform_legacy` singleton
reach are still open