Record document open unsaved prompt closeout
This commit is contained in:
@@ -64,6 +64,12 @@ agent or engineer to remove them without reconstructing context from chat.
|
|||||||
dialog method; the remaining document-open bridge debt stays concentrated in
|
dialog method; the remaining document-open bridge debt stays concentrated in
|
||||||
unsaved-project prompts, project-open execution, layer refresh, title
|
unsaved-project prompts, project-open execution, layer refresh, title
|
||||||
updates, and retained history services.
|
updates, and retained history services.
|
||||||
|
- 2026-06-15: `DEBT-0039` was narrowed again. The retained unsaved-project
|
||||||
|
discard prompt wiring in `LegacyDocumentOpenServices::prompt_discard_unsaved_project()`
|
||||||
|
now routes through a focused helper in `src/legacy_document_open_services.cpp`
|
||||||
|
instead of living inline in the retained document-open service method; the
|
||||||
|
remaining document-open bridge debt stays concentrated in project-open
|
||||||
|
execution, layer refresh, title updates, and retained history services.
|
||||||
- 2026-06-15: `DEBT-0038` was narrowed again. The retained cloud downloaded-
|
- 2026-06-15: `DEBT-0038` was narrowed again. The retained cloud downloaded-
|
||||||
project open camera reset and layer-clear setup in
|
project open camera reset and layer-clear setup in
|
||||||
`execute_legacy_downloaded_project_open()` now routes through a focused
|
`execute_legacy_downloaded_project_open()` now routes through a focused
|
||||||
|
|||||||
@@ -1395,6 +1395,11 @@ The retained document-browse button wiring in `App::dialog_browse()` now also
|
|||||||
routes through a focused helper, so the remaining document-open bridge debt is
|
routes through a focused helper, so the remaining document-open bridge debt is
|
||||||
further concentrated on unsaved-project prompts, project-open execution, layer
|
further concentrated on unsaved-project prompts, project-open execution, layer
|
||||||
refresh, title updates, and retained history services.
|
refresh, title updates, and retained history services.
|
||||||
|
The retained unsaved-project discard prompt wiring in
|
||||||
|
`LegacyDocumentOpenServices::prompt_discard_unsaved_project()` now also routes
|
||||||
|
through a focused helper, so the remaining document-open bridge debt is
|
||||||
|
further concentrated on project-open execution, layer refresh, title updates,
|
||||||
|
and retained history services.
|
||||||
`App::request_close`, `App::save_document`, and
|
`App::request_close`, `App::save_document`, and
|
||||||
`App::continue_document_workflow_after_optional_save` now route through
|
`App::continue_document_workflow_after_optional_save` now route through
|
||||||
app-core document-session executors and `src/legacy_document_session_services.*`,
|
app-core document-session executors and `src/legacy_document_session_services.*`,
|
||||||
|
|||||||
@@ -1667,6 +1667,42 @@ Completed Task Log:
|
|||||||
| --- | --- | ---: | --- | --- |
|
| --- | --- | ---: | --- | --- |
|
||||||
| 2026-06-15 | ADP-044 | no score movement | `powershell -ExecutionPolicy Bypass -File scripts\\automation\\quiet-validate.ps1 -BuildTargets pano_cli -TestRegex "pp_app_core_document_session|pano_cli_plan_document_session_prompt"` | `294d9ce7` |
|
| 2026-06-15 | ADP-044 | no score movement | `powershell -ExecutionPolicy Bypass -File scripts\\automation\\quiet-validate.ps1 -BuildTargets pano_cli -TestRegex "pp_app_core_document_session|pano_cli_plan_document_session_prompt"` | `294d9ce7` |
|
||||||
|
|
||||||
|
### ADP-045 - Extract Document-Open Unsaved Prompt Helper
|
||||||
|
|
||||||
|
Status: Done
|
||||||
|
Score: no score movement
|
||||||
|
Debt: `DEBT-0039`
|
||||||
|
Scope: `src/legacy_document_open_services.cpp` only
|
||||||
|
|
||||||
|
Closeout: `39728e46`
|
||||||
|
|
||||||
|
Goal:
|
||||||
|
|
||||||
|
Reduce the inline retained unsaved-project discard prompt surface by
|
||||||
|
extracting the button wiring from `LegacyDocumentOpenServices::prompt_discard_unsaved_project()`
|
||||||
|
into a focused helper while preserving current behavior.
|
||||||
|
|
||||||
|
Done Checks:
|
||||||
|
|
||||||
|
- The retained unsaved-project discard prompt wiring no longer lives inline in
|
||||||
|
`LegacyDocumentOpenServices::prompt_discard_unsaved_project()`.
|
||||||
|
- The retained unsaved-project discard prompt path now routes through a focused
|
||||||
|
helper in `src/legacy_document_open_services.cpp`.
|
||||||
|
- `DEBT-0039` and the roadmap note the reduced remaining document-open bridge
|
||||||
|
surface.
|
||||||
|
|
||||||
|
Validation:
|
||||||
|
|
||||||
|
```powershell
|
||||||
|
powershell -ExecutionPolicy Bypass -File scripts\\automation\\quiet-validate.ps1 -BuildTargets pano_cli -TestRegex "pp_app_core_document_route|pp_app_core_document_session"
|
||||||
|
```
|
||||||
|
|
||||||
|
Completed Task Log:
|
||||||
|
|
||||||
|
| Date | Task | Score | Validation | Commit |
|
||||||
|
| --- | --- | ---: | --- | --- |
|
||||||
|
| 2026-06-15 | ADP-045 | no score movement | `powershell -ExecutionPolicy Bypass -File scripts\\automation\\quiet-validate.ps1 -BuildTargets pano_cli -TestRegex "pp_app_core_document_route|pp_app_core_document_session"` | `39728e46` |
|
||||||
|
|
||||||
### RND-001 - Make Pure Equirectangular Export The Primary Success Path
|
### RND-001 - Make Pure Equirectangular Export The Primary Success Path
|
||||||
|
|
||||||
Status: Done
|
Status: Done
|
||||||
|
|||||||
Reference in New Issue
Block a user